Sign upLogin

sosia-dev/sosia

View on GitHub
Star

Showing 26 of 30 total issues

Function long_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def long_query(query, q_type, template, refresh=False, view="COMPLETE"):
Severity: Minor
Found in sosia/processing/querying.py - About 35 mins to fix

    Function get_authors_from_sourceyear has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def get_authors_from_sourceyear(df, conn, refresh=False, stacked=False,
    Severity: Minor
    Found in sosia/processing/getting.py - About 35 mins to fix

      Function query_pubs_by_sourceyear has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def query_pubs_by_sourceyear(source_ids, year, stacked=False, refresh=False,
      Severity: Minor
      Found in sosia/processing/querying.py - About 35 mins to fix

        Function get_main_field has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_main_field(fields):
    """Get main 4-digit ASJC field (code) and main 2-digit ASJC field (name).

    Parameters
    ----------
        Severity: Minor
        Found in sosia/processing/extracting.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                    return ScopusSearch(**params).results or []
        Severity: Major
        Found in sosia/processing/querying.py - About 30 mins to fix

          Function inform_matches has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def inform_matches(self, fields=None, verbose=False, refresh=False):
        """Add information to matches to aid in selection process.

        Parameters
        ----------
          Severity: Minor
          Found in sosia/classes/original.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language