sparklemotion/nokogiri

View on GitHub

Showing 400 of 533 total issues

Avoid deeply nested control flow statements.
Open

            if (attr.isId() && id.equals(attr.getValue())) {
              if (foundElement == null) {
                // Continue searching to find duplicates
                foundElement = attr.getOwnerElement();
              } else {
Severity: Major
Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                  if (specifiedPrefix == null &&
                      attr.getNodeName().equals("xmlns")) {
                    // default namespace
                    return value;
                  } else if (attrPrefix != null &&

      Avoid deeply nested control flow statements.
      Open

                  if (node == elem) {
                    elemHandle = getHandleFromNode(elem);
                    break;
                  }
      Severity: Major
      Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    if (prefix != null && !(prefix.equals(XML) || prefix.equals(XMLNS))) {
                      visiblyUtilized.add(prefix);
                    }
        Severity: Major
        Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315Excl.java - About 45 mins to fix

          Method fromRubyToObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            private static Object
            fromRubyToObject(final Ruby runtime, IRubyObject obj)
            {
              if (obj instanceof RubyString) { return obj.asJavaString(); }
              if (obj instanceof RubyBoolean) { return obj.toJava(Boolean.class); }
          Severity: Minor
          Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method visit_attribute_condition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def visit_attribute_condition(node)
                  attribute = node.value.first.accept(self)
                  return attribute if node.value.length == 1
          
                  value = node.value.last
          Severity: Minor
          Found in lib/nokogiri/css/xpath_visitor.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method read_and_encode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def read_and_encode(string, encoding)
                  # Read the string with the given encoding.
                  if string.respond_to?(:read)
                    string = if encoding.nil?
                      string.read
          Severity: Minor
          Found in lib/nokogiri/html5.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method stabilizeAttrs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            private static void
            stabilizeAttrs(Node node)
            {
              if (node.hasAttributes()) {
                NamedNodeMap nodeMap = node.getAttributes();
          Severity: Minor
          Found in ext/java/nokogiri/Html4Document.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method inspect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def inspect
                    # handle the case where an exception is thrown during object construction
                    if respond_to?(:data_ptr?) && !data_ptr?
                      return "#<#{self.class}:#{format("0x%x", object_id)} (no data)>"
                    end
          Severity: Minor
          Found in lib/nokogiri/xml/pp/node.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                  if Nokogiri.jruby?
                    save_options = options[:save_with] || options[1]
                    indent_times = options[:indent] || 0
                  else
                    save_options = options[:save_with] || options[1] || XML::Node::SaveOptions::FORMAT
          Severity: Major
          Found in lib/nokogiri/html5/node.rb - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                    if Nokogiri.jruby?
                      save_options = options[:save_with] || options[1]
                      indent_times = options[:indent] || 0
                    else
                      save_options = options[:save_with] || options[1] || SaveOptions::FORMAT
            Severity: Major
            Found in lib/nokogiri/xml/node.rb - About 40 mins to fix

              Method createTextNode has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                createTextNode(Ruby ruby, String content, int depth, Stack<String> langStack, Stack<String> xmlBaseStack)
              Severity: Minor
              Found in ext/java/nokogiri/internals/ReaderNode.java - About 35 mins to fix

                Method getSchema has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  getSchema(Source source,
                            String currentDir,
                            String scriptFileName,
                            SchemaErrorHandler errorHandler,
                            long parseOptions) throws SAXException
                Severity: Minor
                Found in ext/java/nokogiri/XmlSchema.java - About 35 mins to fix

                  Method resolveResource has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      resolveResource(String type,
                                      String namespaceURI,
                                      String publicId,
                                      String systemId,
                                      String baseURI)
                  Severity: Minor
                  Found in ext/java/nokogiri/XmlSchema.java - About 35 mins to fix

                    Method resolveEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      resolveEntity(Ruby runtime, String name, String publicId, String baseURI, String systemId)
                    Severity: Minor
                    Found in ext/java/nokogiri/internals/NokogiriEntityResolver.java - About 35 mins to fix

                      Method canonicalizeSubTree has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          Node currentNode, NameSpaceSymbTable ns, Node endnode, int documentLevel, CanonicalFilter filter
                      Severity: Minor
                      Found in ext/java/nokogiri/internals/c14n/CanonicalizerBase.java - About 35 mins to fix

                        Method xpath_impl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                              def xpath_impl(node, path, handler, ns, binds)
                        Severity: Minor
                        Found in lib/nokogiri/xml/searchable.rb - About 35 mins to fix

                          Method HTML5 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                            def self.HTML5(input, url = nil, encoding = nil, **options, &block)
                          Severity: Minor
                          Found in lib/nokogiri/html5.rb - About 35 mins to fix

                            Method createImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                              createImpl(Node owner, IRubyObject prefix, String prefixStr, IRubyObject href, String hrefStr)
                            Severity: Minor
                            Found in ext/java/nokogiri/XmlNamespace.java - About 35 mins to fix

                              Method process_recipe has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              def process_recipe(name, version, static_p, cross_p, cacheable_p = true)
                              Severity: Minor
                              Found in ext/nokogiri/extconf.rb - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language