sparklemotion/nokogiri

View on GitHub

Showing 400 of 537 total issues

Method getLocalName has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  public String
  getLocalName(int nodeHandle)
  {
//        if(JJK_NEWCODE)
//        {
Severity: Minor
Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dispatchCharactersEvents has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  public void
  dispatchCharactersEvents(
    int nodeHandle, org.xml.sax.ContentHandler ch,
    boolean normalize)
  throws org.xml.sax.SAXException
Severity: Minor
Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def initialize(document, tags = nil, ctx = nil, options = ParseOptions::DEFAULT_XML) # rubocop:disable Lint/MissingSuper
        return self unless tags

        options = Nokogiri::XML::ParseOptions.new(options) if Integer === options
        @parse_options = options
Severity: Minor
Found in lib/nokogiri/xml/document_fragment.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extractDecls has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  protected IRubyObject[]
  extractDecls(ThreadContext context, Node node)
  {
    List<IRubyObject> decls = new ArrayList<IRubyObject>();
    while (node != null) {
Severity: Minor
Found in ext/java/nokogiri/XmlDtd.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method method_missing has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def method_missing(name, *args, &block)
        if args.empty?
          list = xpath("#{XPATH_PREFIX}#{name.to_s.sub(/^_/, "")}")
        elsif args.first.is_a?(Hash)
          hash = args.first
Severity: Minor
Found in lib/nokogiri/decorators/slop.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def read(len)
        # no support for a call without len

        unless @firstchunk
          (@firstchunk = @io.read(len)) || return
Severity: Minor
Found in lib/nokogiri/html4/encoding_reader.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_element has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def create_element(name, *contents_or_attrs, &block)
        elm = Nokogiri::XML::Element.new(name, self, &block)
        contents_or_attrs.each do |arg|
          case arg
          when Hash
Severity: Minor
Found in lib/nokogiri/xml/document.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createClosingNode has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  createClosingNode(Ruby ruby, String uri, String localName, String qName, int depth, Stack<String> langStack,
                    Stack<String> xmlBaseStack)
Severity: Major
Found in ext/java/nokogiri/internals/ReaderNode.java - About 50 mins to fix

    Avoid deeply nested control flow statements.
    Open

                for (int k = 0; k < nodeMap.getLength(); k++) {
                  if ("charset".equalsIgnoreCase((item = nodeMap.item(k)).getNodeName())) {
                    return item.getNodeValue();
                  }
                }
    Severity: Major
    Found in ext/java/nokogiri/internals/HtmlDomParserContext.java - About 45 mins to fix

      Method native_write has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        @JRubyMethod
        public IRubyObject
        native_write(ThreadContext context, IRubyObject chunk,
                     IRubyObject isLast)
        {
      Severity: Minor
      Found in ext/java/nokogiri/XmlSaxPushParser.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  if (NName.equals("id")) {
                    if (isRealVisible) {
                      // treat xml:id like any other attribute
                      // (emit it, but don't inherit it)
                      result.add(attribute);
      Severity: Major
      Found in ext/java/nokogiri/internals/c14n/Canonicalizer11.java - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    if (attr.isId() && id.equals(attr.getValue())) {
                      if (foundElement == null) {
                        // Continue searching to find duplicates
                        foundElement = attr.getOwnerElement();
                      } else {
        Severity: Major
        Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        if (specifiedPrefix == null &&
                            attr.getNodeName().equals("xmlns")) {
                          // default namespace
                          return value;
                        } else if (attrPrefix != null &&

            Method coalesceTextNodes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              protected static void
              coalesceTextNodes(ThreadContext context,
                                IRubyObject anchorNode,
                                AdoptScheme scheme)
              {
            Severity: Minor
            Found in ext/java/nokogiri/XmlNode.java - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                            if (!namespaceNs.equals(currentAttr.getNamespaceURI())) {
                              continue;
                            }
            Severity: Major
            Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix

              Method getContentImpl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                public CharSequence
                getContentImpl()
                {
                  if (!node.hasChildNodes() && node.getNodeValue() == null &&
                      (node.getNodeType() == Node.TEXT_NODE || node.getNodeType() == Node.CDATA_SECTION_NODE)) {
              Severity: Minor
              Found in ext/java/nokogiri/XmlNode.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                          if (node == elem) {
                            elemHandle = getHandleFromNode(elem);
                            break;
                          }
              Severity: Major
              Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 45 mins to fix

                Method call has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  call(String methodName,
                       IRubyObject arg0,
                       IRubyObject arg1,
                       IRubyObject arg2,
                       IRubyObject arg3,
                Severity: Minor
                Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                              if (attr.isId() && id.equals(attr.getValue()) && se != knownElement) {
                                //log.debug("Multiple elements with the same 'Id' attribute value!");
                                return false;
                              }
                  Severity: Major
                  Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                    if (childElement.hasAttributeNS(namespaceNs,
                                                                    currentAttr.getLocalName())) {
                                      continue;
                                    }
                    Severity: Major
                    Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language