sparklemotion/nokogiri

View on GitHub

Showing 400 of 537 total issues

Method startElement has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  @Override
  public void
  startElement(String uri, String localName, String qName, Attributes attrs) throws SAXException
  {
    final Ruby runtime = this.runtime;
Severity: Minor
Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 1 hr to fix

    Method handleAttributesSubtree has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      @Override
      protected Iterator<Attr>
      handleAttributesSubtree(Element element, NameSpaceSymbTable ns)
      throws CanonicalizationException
      {
    Severity: Minor
    Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315Excl.java - About 1 hr to fix

      Method getDTMHandleFromNode has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        @Override
        public /* synchronized */ int
        getDTMHandleFromNode(org.w3c.dom.Node node)
        {
          //if (node == null) // "node must be non-null for getDTMHandleFromNode!");
      Severity: Minor
      Found in ext/java/nokogiri/internals/XalanDTMManagerPatch.java - About 1 hr to fix

        Method getXPathContext has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          private XPathContext
          getXPathContext(final NokogiriXPathFunctionResolver fnResolver)
          {
            Node doc = context.getNode().getOwnerDocument();
            if (doc == null) { doc = context.getNode(); }
        Severity: Minor
        Found in ext/java/nokogiri/XmlXpathContext.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parseAttributes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private void
            parseAttributes(XMLAttributes attrs, Stack<String> langStack, Stack<String> xmlBaseStack)
            {
              if (attrs.getLength() > 0) { attributeList = new ReaderAttributeList(); }
              String u, n, v;
        Severity: Minor
        Found in ext/java/nokogiri/internals/ReaderNode.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getNamespacesWithPropagated has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          private void
          getNamespacesWithPropagated(List<Attr> namespaces, Attr attr)
          {
            boolean newNamespace = true;
            Iterator<Attr[]> iter = c14nNamespaceStack.iterator();
        Severity: Minor
        Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method op_and has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          @JRubyMethod(name = "&")
          public IRubyObject
          op_and(ThreadContext context, IRubyObject nodeSet)
          {
            IRubyObject[] otherNodes = getNodes(context, nodeSet);
        Severity: Minor
        Found in ext/java/nokogiri/XmlNodeSet.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getInternalSubset has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          public IRubyObject
          getInternalSubset(ThreadContext context)
          {
            IRubyObject dtd = (IRubyObject) node.getUserData(DTD_INTERNAL_SUBSET);
        
        
        Severity: Minor
        Found in ext/java/nokogiri/XmlDocument.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method to_html has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

              def to_html(*args)
                if Nokogiri.jruby?
                  options = args.first.is_a?(Hash) ? args.shift : {}
                  options[:save_with] ||= Node::SaveOptions::DEFAULT_HTML
                  args.insert(0, options)
        Severity: Minor
        Found in lib/nokogiri/xml/node_set.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method iconv_configure_flags has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        def iconv_configure_flags
          # give --with-iconv-dir and --with-opt-dir first priority
          ["iconv", "opt"].each do |target|
            config = preserving_globals { dir_config(target) }
            next unless config.any? && try_link_iconv("--with-#{target}-* flags") { dir_config(target) }
        Severity: Minor
        Found in ext/nokogiri/extconf.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method xpath_for has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

              def xpath_for(
                selector, options = nil,
                prefix: options&.delete(:prefix),
                visitor: options&.delete(:visitor),
                ns: options&.delete(:ns),
        Severity: Minor
        Found in lib/nokogiri/css.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method enter has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public boolean
          enter(Element element)
          {
            if (canonical) {
              c14nNodeList.add(element);
        Severity: Minor
        Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 1 hr to fix

          Method leave has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public void
            leave(Node node)
            {
              if (node instanceof Document) {
                leave((Document)node);
          Severity: Minor
          Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 1 hr to fix

            Method isEqualNode has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              public boolean
              isEqualNode(Node arg)
              {
                if (arg == this) {
                  return true;

              Method getXmlnsAttr has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  void
                  getXmlnsAttr(Collection<Attr> col)
                  {
                    int size = levels.size() - 1;
                    if (cur == null) {
              Severity: Minor
              Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method add_sibling has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                    def add_sibling(next_or_previous, node_or_tags)
                      raise("Cannot add sibling to a node with no parent") unless parent
              
                      impl = next_or_previous == :next ? :add_next_sibling_node : :add_previous_sibling_node
                      iter = next_or_previous == :next ? :reverse_each : :each
              Severity: Minor
              Found in lib/nokogiri/xml/node.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method method_missing has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def method_missing(method, *args, &block)
                        opts = args.last.is_a?(Hash) ? args.pop : {}
                        case method.to_s
                        when /^(.*)!$/
                          @node["id"] = Regexp.last_match(1)
              Severity: Minor
              Found in lib/nokogiri/xml/builder.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method write_to has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                    def write_to(io, *options)
                      return super unless document.is_a?(HTML5::Document)
              
                      options = options.first.is_a?(Hash) ? options.shift : {}
                      encoding = options[:encoding] || options[0]
              Severity: Minor
              Found in lib/nokogiri/html5/node.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method protectAgainstWrappingAttack has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                public static boolean
                protectAgainstWrappingAttack(Node startNode, String value)
                {
                  Node startParent = startNode.getParentNode();
                  Node processedNode;
              Severity: Minor
              Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 1 hr to fix

                Method outputAttrToWriter has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  protected static final void
                  outputAttrToWriter(
                    final String name, final String value,
                    final OutputStream writer, final Map<String, byte[]> cache
                  ) throws IOException
                Severity: Minor
                Found in ext/java/nokogiri/internals/c14n/CanonicalizerBase.java - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language