Sign upLogin

sparkletown/sparkle

View on GitHub
Star
functions/access.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function createToken has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const createToken = async (venueId, uid, password, email, code) => {
  if (!venueId || !uid || (!password && !email && !code)) return undefined;

  const venueRef = admin.firestore().collection("venues").doc(venueId);
  const accessRef = admin.firestore().collection("accessgranted").doc(uid);
Severity: Minor
Found in functions/access.js - About 1 hr to fix

Function checkIsValidToken has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const checkIsValidToken = async (venueId, uid, token) => {
  if (!venueId || !uid || !token) return false;

  const venueRef = admin.firestore().collection("venues").doc(venueId);
  const accessRef = admin.firestore().collection("accessgranted").doc(uid);
Severity: Minor
Found in functions/access.js - About 1 hr to fix

Function checkAccess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

exports.checkAccess = functions.https.onCall(async (data, context) => {
  if (!data || !context) return { token: undefined };

  if (
    context &&
Severity: Minor
Found in functions/access.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status