Sign upLogin

sparkletown/sparkle

View on GitHub
Star
functions/analytics.js

Summary

Maintainability
D
1 day
Test Coverage

Function generateAnalytics has 185 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.generateAnalytics = functions.https.onCall(async (data, context) => {
  checkAuth(context);

  if (!context.auth) {
    throw new HttpsError("internal", `No authentication context`);
Severity: Major
Found in functions/analytics.js - About 7 hrs to fix

Function generateAnalytics has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

exports.generateAnalytics = functions.https.onCall(async (data, context) => {
  checkAuth(context);

  if (!context.auth) {
    throw new HttpsError("internal", `No authentication context`);
Severity: Minor
Found in functions/analytics.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function allDataResult has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const allDataResult = result.map((user) => {
    const onlyVisitIds = user.visits.map((el) => el.id);

    const getVisitData = (visitName) =>
      user.visits.find((visit) => (visit.id === visitName ? visit : 0)) || {
Severity: Minor
Found in functions/analytics.js - About 1 hr to fix

Function getUsersWithVisits has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getUsersWithVisits = async (venueIdsArray) => {
  // @debt see if JS built in .flatMap is good fit for this logic (maybe would require polyfill to be set)
  const dto = flatten(
    await chunk(venueIdsArray, 10)
      .map(async (idsArray) => {
Severity: Minor
Found in functions/analytics.js - About 1 hr to fix

There are no issues that match your filters.

Category
Status