Sign upLogin

spotonlive/sl-navigation

View on GitHub
Star

Showing 4 of 6 total issues

Method renderPage has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function renderPage(Page $page, $maxDepth = null, $depth = 0)
    {
        // Check for depth
        if (!is_null($maxDepth) && $depth > $maxDepth) {
            return null;
Severity: Minor
Found in src/SpotOnLive/Navigation/Navigation/Container.php - About 2 hrs to fix

    Function renderPage has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function renderPage(Page $page, $maxDepth = null, $depth = 0)
    {
        // Check for depth
        if (!is_null($maxDepth) && $depth > $maxDepth) {
            return null;
    Severity: Minor
    Found in src/SpotOnLive/Navigation/Navigation/Container.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function isActive has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function isActive()
    {
        $options = $this->options->get('options');

        /** @var \Illuminate\Routing\Route $currentRoute */
    Severity: Minor
    Found in src/SpotOnLive/Navigation/Navigation/Page.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in src/SpotOnLive/Navigation/Navigation/Page.php - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language