Sign upLogin

spotweb/spotweb

View on GitHub
Star
templates/we1rdo/js/sabpanel.js

Summary

Maintainability
D
2 days
Test Coverage

Function drawGraph has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawGraph(currentSpeed,interval) {
    var numXLabels = 8;
    var numYLabels = 5;

    if($("table.sabGraphData tbody > tr").size() == 1) {
Severity: Major
Found in templates/we1rdo/js/sabpanel.js - About 5 hrs to fix

    Function updateSabPanel has 126 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function updateSabPanel(start,limit) {
    var baseURL = sabBaseURL();
    var url = baseURL+'&action=getstatus';

    $.getJSON(url, function(json){
    Severity: Major
    Found in templates/we1rdo/js/sabpanel.js - About 5 hrs to fix

      File sabpanel.js has 306 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // SabNZBd actions
function sabBaseURL() {
    var apikey = $("div.sabnzbdPanel input.apikey").val();
    return createBaseURL()+'?page=nzbhandlerapi&nzbhandlerapikey='+apikey;
}
      Severity: Minor
      Found in templates/we1rdo/js/sabpanel.js - About 3 hrs to fix

        Function sabActions has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function sabActions(start,limit,action,slot) {
    var baseURL = sabBaseURL();

    if(action == 'pause') {
        var url = baseURL+'&action=pause&id'+slot;
        Severity: Minor
        Found in templates/we1rdo/js/sabpanel.js - About 1 hr to fix

          Function drawGraph has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function drawGraph(currentSpeed,interval) {
    var numXLabels = 8;
    var numYLabels = 5;

    if($("table.sabGraphData tbody > tr").size() == 1) {
          Severity: Minor
          Found in templates/we1rdo/js/sabpanel.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function sabActions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function sabActions(start,limit,action,slot) {
    var baseURL = sabBaseURL();

    if(action == 'pause') {
        var url = baseURL+'&action=pause&id'+slot;
          Severity: Minor
          Found in templates/we1rdo/js/sabpanel.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              $("table.sabQueue tr."+index+" a.up").click(function(){
                        if(timeOut) {clearTimeout(timeOut)}
                        sabActions(start,limit,'up', slot.id);
                    });
          Severity: Major
          Found in templates/we1rdo/js/sabpanel.js and 1 other location - About 1 hr to fix
          templates/we1rdo/js/sabpanel.js on lines 284..287

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              $("table.sabQueue tr."+index+" a.down").click(function(){
                        if(timeOut) {clearTimeout(timeOut)}
                        sabActions(start,limit,'down', slot.id);
                    });
          Severity: Major
          Found in templates/we1rdo/js/sabpanel.js and 1 other location - About 1 hr to fix
          templates/we1rdo/js/sabpanel.js on lines 280..283

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if(queue.nrofdownloads != 0 && queue.nrofdownloads > end) {
            $("table.sabQueue").append("<tr class='nav'><td><t>Show %1 till %2 from a total of %3 results</t></td></tr>".replace('%1', start).replace('%2', end).replace('%3', queue.nrofdownloads));
        } else if(queue.nrofdownloads != 0 && end > queue.nrofdownloads) {
            if(queue.nrofdownloads == 1) {
                $("table.sabQueue").append("<tr class='nav'><td><t>Show 1 result</t></td></tr>");
          Severity: Minor
          Found in templates/we1rdo/js/sabpanel.js and 1 other location - About 45 mins to fix
          templates/we1rdo/js/sabpanel.js on lines 308..310

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if(queue.nrofdownloads != 0 && end == queue.nrofdownloads) {
            $("table.sabQueue").append("<tr class='nav'><td><t>Show %1 till %2 from a total of %3 results</t></td></tr>".replace('%1', start).replace('%2', end).replace('%3', queue.nrofdownloads));
        }
          Severity: Minor
          Found in templates/we1rdo/js/sabpanel.js and 1 other location - About 45 mins to fix
          templates/we1rdo/js/sabpanel.js on lines 300..310

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status