Sign upLogin

spotweb/spotweb

View on GitHub
Star
templates/we1rdo/js/spotdialogs.js

Summary

Maintainability
C
1 day
Test Coverage

Function openDialog has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

function openDialog(divid, title, url, buttonClick, successAction, closeCb, openCb) {
    var $dialdiv = $("#" + divid);

    /*
     * Test whether we need to 'dialog'-ify the
Severity: Minor
Found in templates/we1rdo/js/spotdialogs.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function openDialog has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function openDialog(divid, title, url, buttonClick, successAction, closeCb, openCb) {
    var $dialdiv = $("#" + divid);

    /*
     * Test whether we need to 'dialog'-ify the
Severity: Major
Found in templates/we1rdo/js/spotdialogs.js - About 3 hrs to fix

    Function buttonClick has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            var buttonClick = function() {
            /*
             * The current 'this' is where the submitt button has been pushed,
             * this means we can assume we are in the form itselve.
             */
    Severity: Minor
    Found in templates/we1rdo/js/spotdialogs.js - About 1 hr to fix

      Function success has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      success: function(data) {
                    /*
                     * Upon success (of the HTTP call), we try to find the
                     * dialog again and act upon the chosen action
                     */
      Severity: Minor
      Found in templates/we1rdo/js/spotdialogs.js - About 1 hr to fix

        Function openDialog has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function openDialog(divid, title, url, buttonClick, successAction, closeCb, openCb) {
        Severity: Major
        Found in templates/we1rdo/js/spotdialogs.js - About 50 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                  if ((successAction == 'showresultsonly') && (data.result == 'success')) {
                            $dialdiv.empty();

                            /* Create the empty elements to show the errors/information in */
                            $dialdiv.html("<ul class='formerrors'></ul><ul class='forminformation'></ul>");
          Severity: Minor
          Found in templates/we1rdo/js/spotdialogs.js and 1 other location - About 50 mins to fix
          templates/mobile/includes/js/spotdialogs.js on lines 47..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                  $.each(data.errors, function(key, val) {
                            $formerrors.append("<li>" + val + "</li>");
                        }); // each
          Severity: Minor
          Found in templates/we1rdo/js/spotdialogs.js and 1 other location - About 30 mins to fix
          templates/mobile/includes/js/spotdialogs.js on lines 56..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status