Showing 6 of 6 total issues
Method validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def validate(line_item)
line_item.quantity_by_variant.each do |variant, variant_quantity|
inventory_units = line_item.inventory_units.where(variant: variant).count
quantity = variant_quantity - inventory_units
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_to_line_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def add_to_line_item(variant, quantity, options = {})
line_item = grab_line_item_by_variant(variant, false, options)
if line_item && part_variants_match?(line_item, variant, quantity, options)
line_item.quantity += quantity.to_i- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_to_line_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def add_to_line_item(order:, variant:, quantity: nil, public_metadata: {}, private_metadata: {}, options: {})
options ||= {}
quantity ||= 1
line_item = Spree::Dependencies.line_item_by_variant_finder.constantize.new.execute(order: order, variant: variant, options: options)
line_item_created = line_item.nil?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_inventory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update_inventory
if (changed? || target_shipment.present?) &&
order.has_checkout_step?("delivery")
if product.assembly?
Spree::OrderInventoryAssembly.new(self).verify(target_shipment)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method verify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def verify(shipment = nil)
if order.completed? || shipment.present?
line_item.quantity_by_variant.each do |part, total_parts|
if Gem.loaded_specs['spree_core'].version >= Gem::Version.create('3.3.0')- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method verify_remove_from_shipment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def verify_remove_from_shipment(shipment, total_parts, existing_parts)
quantity = existing_parts - total_parts
if shipment.present?
remove_from_shipment(shipment, quantity)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"