Showing 5 of 5 total issues
Method consume_users_credit has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def consume_users_credit
return unless completed? and user.present?
credit_used = self.store_credit_amount
user.store_credits.each do |store_credit|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method store_credit_maximum_usable_amount has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def store_credit_maximum_usable_amount
if user.store_credits_total > 0
user.store_credits_total > store_credit_maximum_amount ? store_credit_maximum_amount : user.store_credits_total
else
0- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_store_credit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def process_store_credit
@store_credit_amount = BigDecimal.new(@store_credit_amount.to_s).round(2)
# store credit can't be greater than order total (not including existing credit), or the user's available credit
@store_credit_amount = [@store_credit_amount, user.store_credits_total, (total + store_credit_amount.abs)].min- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def validate(record)
return unless Spree::Config[:use_store_credit_minimum]
return if record.item_total >= Spree::Config[:use_store_credit_minimum]
return unless record.errors.empty?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method remove_payments_attributes_if_total_is_zero has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def remove_payments_attributes_if_total_is_zero
load_order_with_lock
return unless params[:order] && params[:order][:store_credit_amount]
parsed_credit = Spree::Price.new- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"