Sign upLogin

springload/workshops

View on GitHub
Star

Showing 16 of 36 total issues

Function update_quality has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
Open

function update_quality(items) {
    for (var i = 0; i < items.length; i++) {
        if (items[i].name != 'Aged Brie' && items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
            if (items[i].quality > 0) {
                if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
Severity: Minor
Found in writing-good-code/src/gilded_rose.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_quality has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
Open

function update_quality(items) {
  for (var i = 0; i < items.length; i++) {
    if (items[i].name != 'Aged Brie' && items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
      if (items[i].quality > 0) {
        if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
Severity: Minor
Found in tdd-workshop/src/gilded_rose.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_quality has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function update_quality(items) {
  for (var i = 0; i < items.length; i++) {
    if (items[i].name != 'Aged Brie' && items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
      if (items[i].quality > 0) {
        if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
Severity: Minor
Found in tdd-workshop/src/gilded_rose.js - About 1 hr to fix

    Function update_quality has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function update_quality(items) {
    for (var i = 0; i < items.length; i++) {
        if (items[i].name != 'Aged Brie' && items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
            if (items[i].quality > 0) {
                if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
    Severity: Minor
    Found in writing-good-code/src/gilded_rose.js - About 1 hr to fix

      Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          render() {
        const { products, filterText, inStockOnly } = this.props;

        const rows = [];
        let currentCategory;
      Severity: Minor
      Found in thinking-in-react/solution4.js - About 1 hr to fix

        Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            render() {
        const { products, filterText, inStockOnly } = this.props;

        const rows = [];
        let currentCategory;
        Severity: Minor
        Found in thinking-in-react/solution6.js - About 1 hr to fix

          Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              render() {
        const { products, filterText, inStockOnly } = this.props;

        const rows = [];
        let currentCategory;
          Severity: Minor
          Found in thinking-in-react/solution5.js - About 1 hr to fix

            Function update has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function update(item) {
    switch (item.name) {
    case 'Backstage passes to a TAFKAL80ETC concert':
        item.quality = change_quality(item.quality, 1);
            Severity: Minor
            Found in writing-good-code/src/gilded_rose_solution.js - About 1 hr to fix

              Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  render() {
        const products = this.props.products;

        const rows = [];
        let currentCategory;
              Severity: Minor
              Found in thinking-in-react/solution3.js - About 1 hr to fix

                Function update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                function update(item) {
    switch (item.name) {
    case 'Backstage passes to a TAFKAL80ETC concert':
        item.quality = change_quality(item.quality, 1);
                Severity: Minor
                Found in writing-good-code/src/gilded_rose_solution.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                          if (items[i].sell_in < 6) {
            if (items[i].quality < 50) {
              items[i].quality = items[i].quality + 1
            }
          }
                Severity: Major
                Found in tdd-workshop/src/gilded_rose.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                            if (items[i].sell_in < 11) {
            if (items[i].quality < 50) {
              items[i].quality = items[i].quality + 1
            }
          }
                  Severity: Major
                  Found in tdd-workshop/src/gilded_rose.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        if (items[i].quality > 0) {
                        if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
                            items[i].quality = items[i].quality - 1
                        }
                    }
                    Severity: Major
                    Found in writing-good-code/src/gilded_rose.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          if (items[i].sell_in < 6) {
                        if (items[i].quality < 50) {
                            items[i].quality = items[i].quality + 1
                        }
                    }
                      Severity: Major
                      Found in writing-good-code/src/gilded_rose.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if (items[i].sell_in < 11) {
                        if (items[i].quality < 50) {
                            items[i].quality = items[i].quality + 1
                        }
                    }
                        Severity: Major
                        Found in writing-good-code/src/gilded_rose.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                    if (items[i].quality > 0) {
            if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
              items[i].quality = items[i].quality - 1
            }
          }
                          Severity: Major
                          Found in tdd-workshop/src/gilded_rose.js - About 45 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language