spritejs/spritejs

View on GitHub
src/node/cloud.js

Summary

Maintainability
D
2 days
Test Coverage
F
2%

Avoid too many return statements within this function.
Open

    return true;
Severity: Major
Found in src/node/cloud.js - About 30 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      setFillColor(idx, color) {
        if(this.meshCloud) {
          if(Array.isArray(color)) {
            color = [...color];
            color[0] /= 255;
    Severity: Major
    Found in src/node/cloud.js and 1 other location - About 3 hrs to fix
    src/node/cloud.js on lines 217..228

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      setStrokeColor(idx, color) {
        if(this.meshCloud) {
          if(Array.isArray(color)) {
            color = [...color];
            color[0] /= 255;
    Severity: Major
    Found in src/node/cloud.js and 1 other location - About 3 hrs to fix
    src/node/cloud.js on lines 191..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              Object.entries(uniforms).forEach(([key, value]) => {
                if(typeof value === 'function') {
                  value = value(this, key);
                }
                _uniform[key] = value;
    Severity: Major
    Found in src/node/cloud.js and 1 other location - About 1 hr to fix
    src/node/node.js on lines 366..371

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      sepia(idx, p) {
        if(this.meshCloud) {
          this.meshCloud.sepia(idx, p);
          this.forceUpdate();
        }
    Severity: Minor
    Found in src/node/cloud.js and 1 other location - About 40 mins to fix
    src/node/cloud.js on lines 127..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      invert(idx, p) {
        if(this.meshCloud) {
          this.meshCloud.invert(idx, p);
          this.forceUpdate();
        }
    Severity: Minor
    Found in src/node/cloud.js and 1 other location - About 40 mins to fix
    src/node/cloud.js on lines 204..209

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      setColorTransform(idx, m) {
        if(this.meshCloud) {
          this.meshCloud.setColorTransform(idx, m);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      contrast(idx, p) {
        if(this.meshCloud) {
          this.meshCloud.contrast(idx, p);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      transformColor(idx, m) {
        if(this.meshCloud) {
          this.meshCloud.transformColor(idx, m);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      grayscale(idx, p) {
        if(this.meshCloud) {
          this.meshCloud.grayscale(idx, p);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      setOpacity(idx, p) {
        if(this.meshCloud) {
          this.meshCloud.opacity(idx, p);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      saturate(idx, p) {
        if(this.meshCloud) {
          this.meshCloud.saturate(idx, p);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      brightness(idx, p) {
        if(this.meshCloud) {
          this.meshCloud.brightness(idx, p);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      setTransform(idx, m) {
        if(this.meshCloud) {
          this.meshCloud.setTransform(idx, m);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      hueRotate(idx, deg) {
        if(this.meshCloud) {
          this.meshCloud.hueRotate(idx, deg);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 245..250
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      transform(idx, m) {
        if(this.meshCloud) {
          this.meshCloud.transform(idx, m);
          this.forceUpdate();
        }
    Severity: Major
    Found in src/node/cloud.js and 9 other locations - About 35 mins to fix
    src/node/cloud.js on lines 53..58
    src/node/cloud.js on lines 60..65
    src/node/cloud.js on lines 113..118
    src/node/cloud.js on lines 120..125
    src/node/cloud.js on lines 150..155
    src/node/cloud.js on lines 166..171
    src/node/cloud.js on lines 184..189
    src/node/cloud.js on lines 230..235
    src/node/cloud.js on lines 252..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status