squareteam/yodatra

View on GitHub

Showing 4 of 4 total issues

Method retrieve_resources has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    def retrieve_resources(action)
      pass unless involved?
      no_route if disabled? action

      model = model_name.constantize
Severity: Minor
Found in lib/yodatra/models_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method nested_resources has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def nested_resources
      resources = nil
      begin
        parent_model = params[:captures].first.classify.constantize
        parent_controller = "#{parent_model}sController".constantize
Severity: Minor
Found in lib/yodatra/models_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method involved has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def involved
      involved = params[:splat] && params[:splat].first
      params[:captures].each_index { |i|
        involved ||= params[:captures].last(i+1).first if !params[:captures].last(i+1).first.nil? && params[:captures].last(i+1).first.match(/[\d]+/).nil?
      } unless params[:captures].nil?
Severity: Minor
Found in lib/yodatra/models_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method registered has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.registered app
      raise "Check it out O'man! You're trying to boot the app [#{app}] which is already booted!" if app.booted
      if app.booting
        # ActiveRecord
        app.register Sinatra::ActiveRecordExtension
Severity: Minor
Found in lib/yodatra/boot.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language