Sign upLogin

srustamov/laravel-file-manager

View on GitHub
Star

Showing 6 of 10 total issues

File FileManagerController.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Srustamov\FileManager\Controllers;

use Exception;
Severity: Minor
Found in src/Controllers/FileManagerController.php - About 2 hrs to fix

    Function zip has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function zip($source, $destination): ?array
    {
        ini_set('max_execution_time', 600);
        ini_set('memory_limit', '1024M');
    Severity: Minor
    Found in src/Services/FileService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method zip has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function zip($source, $destination): ?array
    {
        ini_set('max_execution_time', 600);
        ini_set('memory_limit', '1024M');
    Severity: Minor
    Found in src/Services/FileService.php - About 1 hr to fix

      Method getFileContent has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getFileContent(Request $request): JsonResponse
    {
        $path = $this->service->absolutePath($request->post('path'));

        if (File::isFile($path)) {
      Severity: Minor
      Found in src/Controllers/FileManagerController.php - About 1 hr to fix

        Method createFile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createFile(FileCreateRequest $request): ?JsonResponse
    {
        $parent = rtrim($this->service->absolutePath($request->post('parent')), FileService::DS);

        $filename = trim($request->name, FileService::DS);
        Severity: Minor
        Found in src/Controllers/FileManagerController.php - About 1 hr to fix

          Function getFileContent has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getFileContent(Request $request): JsonResponse
    {
        $path = $this->service->absolutePath($request->post('path'));

        if (File::isFile($path)) {
          Severity: Minor
          Found in src/Controllers/FileManagerController.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language