Sign upLogin

ssut/telegram-rb

View on GitHub
Star

Showing 12 of 12 total issues

Method format_message has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    def format_message
      message = Message.new

      message.id = @id
      message.text = @raw_data['text'] ||= ''
Severity: Minor
Found in lib/telegram/events.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_chats! has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def update_chats!
      assert!
      callback = Callback.new
      
      collected = 0
Severity: Minor
Found in lib/telegram/api.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_data has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def process_data
      process = Proc.new { |data|
        begin
          type = case data['event']
          when 'message'
Severity: Minor
Found in lib/telegram/client.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method format_message has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def format_message
      message = Message.new

      message.id = @id
      message.text = @raw_data['text'] ||= ''
Severity: Minor
Found in lib/telegram/events.rb - About 1 hr to fix

    Method update_chats! has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def update_chats!
      assert!
      callback = Callback.new
      
      collected = 0
    Severity: Minor
    Found in lib/telegram/api.rb - About 1 hr to fix

      Method process_data has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def process_data
      process = Proc.new { |data|
        begin
          type = case data['event']
          when 'message'
      Severity: Minor
      Found in lib/telegram/client.rb - About 1 hr to fix

        Method update_contacts! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def update_contacts!
      assert!
      callback = Callback.new
      @contacts = []
      @connection.communicate('contact_list') do |success, data|
        Severity: Minor
        Found in lib/telegram/api.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update_profile! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def update_profile!
      assert!
      callback = Callback.new
      @profile = nil
      @connection.communicate('get_self') do |success, data|
        Severity: Minor
        Found in lib/telegram/api.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def update!(&cb)
      done = false
      EM.synchrony do
        multi = EM::Synchrony::Multi.new
        multi.add :profile, update_profile!
        Severity: Minor
        Found in lib/telegram/api.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method reply has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def reply(type, content, target=nil, &callback)
      target = @target if target.nil?

      case type
      when :text
        Severity: Minor
        Found in lib/telegram/models.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(client, contact)
      @client = client
      @contact = contact

      @id = contact['peer_id']
        Severity: Minor
        Found in lib/telegram/models.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(client, event = EventType::UNKNOWN_EVENT, action = ActionType::NO_ACTION, data = {})
      @client = client
      @id = data.respond_to?(:[]) ? data['id'] : ''
      @message = nil
      @tgmessage = nil
        Severity: Minor
        Found in lib/telegram/events.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language