Sign upLogin

staempfli/magento2-module-mailcatcher

View on GitHub
Star

Showing 2 of 6 total issues

Function getAddressWithRedirectRecipient has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function getAddressWithRedirectRecipient($address, $redirectRecipient)
    {
        if (is_array($address)) {
            foreach ($address as &$email) {
                if (!$this->mailCatcherRepository->isRecipientWhiteListed($email)) {
Severity: Minor
Found in Mail/Message.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Message $message,
        MailCatcherLogger $mailCatcherLogger,
        TransportInterface $originalTransport,
        CatcherConfig $catcherConfig,
        MailCatcherRepository $mailCatcherRepository
Severity: Minor
Found in Transport/MailCatcherTransportProxy.php - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language