Sign upLogin

starburstgem/starburst

View on GitHub
Star

Showing 1 of 122 total issues

Method mark_as_read has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def mark_as_read
            announcement = Announcement.find(params[:id].to_i)
            if respond_to?(Starburst.current_user_method, true) && send(Starburst.current_user_method) && announcement
                if AnnouncementView.where(user_id: send(Starburst.current_user_method).id, announcement_id: announcement.id).first_or_create(user_id: send(Starburst.current_user_method).id, announcement_id: announcement.id)
                    render :json => :ok
Severity: Minor
Found in app/controllers/starburst/announcements_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language