Sign upLogin

stevenhaddox/omniauth-dice

View on GitHub
Star

Showing 3 of 17 total issues

Class Dice has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Dice
      include OmniAuth::Strategy
      attr_accessor :dn, :raw_dn, :data

      option :dnc_options, {}
Severity: Minor
Found in lib/omniauth/strategies/dice.rb - About 4 hrs to fix

    File dice.rb has 286 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'faraday'
require 'faraday_middleware'
require 'open-uri'
require 'omniauth'
require 'cert_munger'
    Severity: Minor
    Found in lib/omniauth/strategies/dice.rb - About 2 hrs to fix

      Method request_phase has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def request_phase
        validate_required_params
        subject_dn = get_dn_by_type('subject')
        return fail!('You need a valid DN to authenticate.') unless subject_dn
        user_dn = format_dn(subject_dn)
      Severity: Minor
      Found in lib/omniauth/strategies/dice.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language