Sign upLogin

streetmix/streetmix

View on GitHub
Star
client/src/segments/buildings.js

Summary

Maintainability
D
2 days
Test Coverage

Function drawBuilding has 129 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function drawBuilding (
  ctx,
  variant,
  floors,
  position,
Severity: Major
Found in client/src/segments/buildings.js - About 5 hrs to fix

Function drawBuilding has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

export function drawBuilding (
  ctx,
  variant,
  floors,
  position,
Severity: Minor
Found in client/src/segments/buildings.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File buildings.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import seedrandom from 'seedrandom'
import { generateRandSeed } from '../util/random'
import { prettifyWidth, round } from '../util/width_units'
import { images } from '../app/load_resources'
import store from '../store'
Severity: Minor
Found in client/src/segments/buildings.js - About 3 hrs to fix

Function createBuilding has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createBuilding (el, variant, position, floors, shadeIn) {
  const elementWidth = el.offsetWidth

  // Determine building dimensions
  const building = BUILDINGS[variant]
Severity: Minor
Found in client/src/segments/buildings.js - About 1 hr to fix

Function drawBuilding has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

  ctx,
  variant,
  floors,
  position,
  totalWidth,
Severity: Major
Found in client/src/segments/buildings.js - About 1 hr to fix

Function createBuilding has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

export function createBuilding (el, variant, position, floors, shadeIn) {
Severity: Minor
Found in client/src/segments/buildings.js - About 35 mins to fix

Function prettifyHeight has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  variant,
  position,
  floors,
  units,
  formatMessage
Severity: Minor
Found in client/src/segments/buildings.js - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  arcade: {
    id: 'arcade',
    label: 'Arcade building',
    spriteId: 'buildings--arcade',
    hasFloors: true,
Severity: Major
Found in client/src/segments/buildings.js and 1 other location - About 1 hr to fix
client/src/segments/buildings.js on lines 93..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  wide: {
    id: 'wide',
    label: 'Building',
    spriteId: 'buildings--apartments-wide',
    hasFloors: true,
Severity: Major
Found in client/src/segments/buildings.js and 1 other location - About 1 hr to fix
client/src/segments/buildings.js on lines 104..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status