Sign upLogin

streetmix/streetmix

View on GitHub
Star
client/src/streets/thumbnail.js

Summary

Maintainability
F
4 days
Test Coverage

File thumbnail.js has 506 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { images } from '../app/load_resources'
import { drawLine } from '../util/canvas_drawing'
import { prettifyWidth } from '../util/width_units'
import { getSkyboxDef, makeCanvasGradientStopArray } from '../sky'
import {
Severity: Major
Found in client/src/streets/thumbnail.js - About 1 day to fix

Function drawSegmentNamesAndWidths has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawSegmentNamesAndWidths (
  ctx,
  street,
  dpi,
  multiplier,
Severity: Major
Found in client/src/streets/thumbnail.js - About 2 hrs to fix

Function drawWatermark has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawWatermark (ctx, dpi, invert = false) {
  const text = formatMessage(
    'export.watermark',
    'Made with {streetmixWordmark}',
    {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 1 hr to fix

Function drawClouds has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawClouds (ctx, width, height, dpi, sky) {
  // Handle cloud opacity
  ctx.save()
  ctx.globalAlpha = sky.cloudOpacity ?? 1
Severity: Minor
Found in client/src/streets/thumbnail.js - About 1 hr to fix

Function drawStreetNameplate has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawStreetNameplate (ctx, street, width, dpi) {
  let text = street.name || formatMessage('street.default-name', 'Unnamed St')

  ctx.textAlign = 'center'
  ctx.textBaseline = 'center'
Severity: Minor
Found in client/src/streets/thumbnail.js - About 1 hr to fix

Function drawBuildings has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawBuildings (
  ctx,
  street,
  width,
  dpi,
Severity: Minor
Found in client/src/streets/thumbnail.js - About 1 hr to fix

Function drawSegments has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawSegments (ctx, street, dpi, multiplier, groundLevel, offsetLeft) {
  // Collect z-indexes
  const zIndexes = []
  for (const segment of street.segments) {
    const segmentInfo = getSegmentInfo(segment.type)
Severity: Minor
Found in client/src/streets/thumbnail.js - About 1 hr to fix

Function drawSky has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawSky (
  ctx,
  street,
  width,
  height,
Severity: Minor
Found in client/src/streets/thumbnail.js - About 1 hr to fix

Function drawSky has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

  ctx,
  street,
  width,
  height,
  dpi,
Severity: Major
Found in client/src/streets/thumbnail.js - About 1 hr to fix

Function drawSegments has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function drawSegments (ctx, street, dpi, multiplier, groundLevel, offsetLeft) {
  // Collect z-indexes
  const zIndexes = []
  for (const segment of street.segments) {
    const segmentInfo = getSegmentInfo(segment.type)
Severity: Minor
Found in client/src/streets/thumbnail.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drawSegmentNamesAndWidths has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function drawSegmentNamesAndWidths (
  ctx,
  street,
  dpi,
  multiplier,
Severity: Minor
Found in client/src/streets/thumbnail.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drawGround has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  ctx,
  street,
  width,
  dpi,
  multiplier,
Severity: Major
Found in client/src/streets/thumbnail.js - About 50 mins to fix

Function drawBuildings has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  ctx,
  street,
  width,
  dpi,
  multiplier,
Severity: Major
Found in client/src/streets/thumbnail.js - About 50 mins to fix

Function drawBackgroundObjects has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function drawBackgroundObjects (ctx, width, height, dpi, multiplier, objects) {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 45 mins to fix

Function drawSegmentNamesBackground has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  ctx,
  width,
  height,
  dpi,
  multiplier,
Severity: Minor
Found in client/src/streets/thumbnail.js - About 45 mins to fix

Function drawBackgroundImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function drawBackgroundImage (ctx, width, height, dpi, multiplier, imageId) {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 45 mins to fix

Function drawSegments has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function drawSegments (ctx, street, dpi, multiplier, groundLevel, offsetLeft) {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 45 mins to fix

Function drawSegmentNamesAndWidths has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  ctx,
  street,
  dpi,
  multiplier,
  groundLevel,
Severity: Minor
Found in client/src/streets/thumbnail.js - About 45 mins to fix

Function drawStreetThumbnail has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export function drawStreetThumbnail (
  ctx,
  street,
  {
    width,
Severity: Minor
Found in client/src/streets/thumbnail.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drawClouds has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function drawClouds (ctx, width, height, dpi, sky) {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 35 mins to fix

Function drawBackgroundGradient has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function drawBackgroundGradient (ctx, width, height, dpi, backgroundGradient) {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 35 mins to fix

Function drawBackgroundColor has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function drawBackgroundColor (ctx, width, height, dpi, color) {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 35 mins to fix

Function drawWatermark has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function drawWatermark (ctx, dpi, invert = false) {
  const text = formatMessage(
    'export.watermark',
    'Made with {streetmixWordmark}',
    {
Severity: Minor
Found in client/src/streets/thumbnail.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  for (let i = 0; i < Math.floor(width / skyRearWidth) + 1; i++) {
    ctx.drawImage(
      skyRearImg.img,
      0,
      0,
Severity: Major
Found in client/src/streets/thumbnail.js and 1 other location - About 1 hr to fix
client/src/streets/thumbnail.js on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  for (let i = 0; i < Math.floor(width / skyFrontWidth) + 1; i++) {
    ctx.drawImage(
      skyFrontImg.img,
      0,
      0,
Severity: Major
Found in client/src/streets/thumbnail.js and 1 other location - About 1 hr to fix
client/src/streets/thumbnail.js on lines 255..267

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status