Sign upLogin

strikeentco/yarl

View on GitHub
Star
main.js

Summary

Maintainability
D
2 days
Test Coverage

Function normalize has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

async function normalize(url, opts) {
  opts = Object.assign(
    { protocol: 'http:', path: '', encoding: 'utf8', redirectCount: 10 },
    typeof url === 'string' ? urlParse(prependHTTP(url), true) : url,
    opts
Severity: Minor
Found in main.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function request has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function request(opts, resolve, reject, redirectCount) {
  const fn = (opts.protocol === 'https:') ? https : http;
  const req = fn.request(opts, (res) => {
    const { statusCode } = res;
    if (isRedirect(statusCode) && 'location' in res.headers) {
Severity: Major
Found in main.js - About 3 hrs to fix

    Function req has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const req = fn.request(opts, (res) => {
    const { statusCode } = res;
    if (isRedirect(statusCode) && 'location' in res.headers) {
      if (opts.forceRedirect || isRedirectAll(statusCode) || (opts.method === 'GET' || opts.method === 'HEAD')) {
        if (++redirectCount > opts.redirectCount) {
    Severity: Major
    Found in main.js - About 2 hrs to fix

      Function normalize has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function normalize(url, opts) {
  opts = Object.assign(
    { protocol: 'http:', path: '', encoding: 'utf8', redirectCount: 10 },
    typeof url === 'string' ? urlParse(prependHTTP(url), true) : url,
    opts
      Severity: Major
      Found in main.js - About 2 hrs to fix

        Function request has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

        function request(opts, resolve, reject, redirectCount) {
  const fn = (opts.protocol === 'https:') ? https : http;
  const req = fn.request(opts, (res) => {
    const { statusCode } = res;
    if (isRedirect(statusCode) && 'location' in res.headers) {
        Severity: Minor
        Found in main.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

            if (
      !isString(opts.body) && !Buffer.isBuffer(opts.body) && !(opts.form || opts.json)
      && !(isObject(opts.body) && opts.multipart)
    ) {
      throw new TypeError('options.body must be a String, Buffer or plain Object');
        Severity: Major
        Found in main.js - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (opts.form) {
        opts.headers['content-type'] = opts.headers['content-type'] || 'application/x-www-form-urlencoded';
        opts.body = qs.stringify(opts.body);
      } else {
          Severity: Minor
          Found in main.js and 1 other location - About 55 mins to fix
          main.js on lines 103..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                } else {
        opts.headers['content-type'] = opts.headers['content-type'] || 'application/json';
        opts.body = JSON.stringify(opts.body);
      }
          Severity: Minor
          Found in main.js and 1 other location - About 55 mins to fix
          main.js on lines 100..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status