Sign upLogin

string-searching/matiyasevich-knuth-morris-pratt

View on GitHub
Star
src/fastScan.js

Summary

Maintainability
D
1 day
Test Coverage

Function fastScan has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

export default function* fastScan(p, pi, pj, t, ti, s, si, sj) {
    assert(pj - pi >= 2);
    assert(sj - si >= 2);
    const pn = pj - pi;
    const m0 = t[ti + pn];
Severity: Minor
Found in src/fastScan.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fastScan has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function* fastScan(p, pi, pj, t, ti, s, si, sj) {
    assert(pj - pi >= 2);
    assert(sj - si >= 2);
    const pn = pj - pi;
    const m0 = t[ti + pn];
Severity: Minor
Found in src/fastScan.js - About 1 hr to fix

    Function fastScan has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export default function* fastScan(p, pi, pj, t, ti, s, si, sj) {
    Severity: Major
    Found in src/fastScan.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                      } else if (++si === sj) return;
      Severity: Major
      Found in src/fastScan.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if (m0 === 0) continue loop;
        Severity: Major
        Found in src/fastScan.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if (++si === sj) return;
          Severity: Major
          Found in src/fastScan.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if (si === sj) return;
            Severity: Major
            Found in src/fastScan.js - About 45 mins to fix

              Avoid too many return statements within this function.
              Open

                                  if (++si === sj) return;
              Severity: Major
              Found in src/fastScan.js - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status