Sign upLogin

strongloop/express

View on GitHub
Star
lib/router/index.js

Summary

Maintainability
F
4 days
Test Coverage

Function handle has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

proto.handle = function handle(req, res, out) {
  var self = this;

  debug('dispatching %s %s', req.method, req.url);
Severity: Minor
Found in lib/router/index.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File index.js has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * express
 * Copyright(c) 2009-2013 TJ Holowaychuk
 * Copyright(c) 2013 Roman Shtylman
 * Copyright(c) 2014-2015 Douglas Christopher Wilson
Severity: Minor
Found in lib/router/index.js - About 5 hrs to fix

    Function handle has 127 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    proto.handle = function handle(req, res, out) {
  var self = this;

  debug('dispatching %s %s', req.method, req.url);
    Severity: Major
    Found in lib/router/index.js - About 5 hrs to fix

      Function next has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function next(err) {
    var layerError = err === 'route'
      ? null
      : err;
      Severity: Major
      Found in lib/router/index.js - About 3 hrs to fix

        Function process_params has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

        proto.process_params = function process_params(layer, called, req, res, done) {
  var params = this.params;

  // captured parameters from the layer, keys and values
  var keys = layer.keys;
        Severity: Minor
        Found in lib/router/index.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function process_params has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        proto.process_params = function process_params(layer, called, req, res, done) {
  var params = this.params;

  // captured parameters from the layer, keys and values
  var keys = layer.keys;
        Severity: Major
        Found in lib/router/index.js - About 2 hrs to fix

          Function use has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          proto.use = function use(fn) {
  var offset = 0;
  var path = '/';

  // default path to '/'
          Severity: Minor
          Found in lib/router/index.js - About 1 hr to fix

            Function use has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            proto.use = function use(fn) {
  var offset = 0;
  var path = '/';

  // default path to '/'
            Severity: Minor
            Found in lib/router/index.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function param has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function param(err) {
    if (err) {
      return done(err);
    }
            Severity: Minor
            Found in lib/router/index.js - About 1 hr to fix

              Function process_params has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              proto.process_params = function process_params(layer, called, req, res, done) {
              Severity: Minor
              Found in lib/router/index.js - About 35 mins to fix

                Function mergeParams has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                function mergeParams(params, parent) {
  if (typeof parent !== 'object' || !parent) {
    return params;
  }
                Severity: Minor
                Found in lib/router/index.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function param has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                proto.param = function param(name, fn) {
  // param logic
  if (typeof name === 'function') {
    deprecate('router.param(fn): Refactor to use path params');
    this._params.push(name);
                Severity: Minor
                Found in lib/router/index.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this function.
                Open

                      return done(layerError);
                Severity: Major
                Found in lib/router/index.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (typeof fn !== 'function') {
    var arg = fn;

    while (Array.isArray(arg) && arg.length !== 0) {
      arg = arg[0];
                  Severity: Major
                  Found in lib/router/index.js and 1 other location - About 2 hrs to fix
                  lib/application.js on lines 200..212

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 92.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status