Sign upLogin

stupidpupil/kerberos_authenticator

View on GitHub
Star

Showing 3 of 3 total issues

Method authenticate! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def authenticate!
        resource = mapping.to.where(email: params['user']['email']).first
        fail(:not_found_in_database) and return unless validate(resource)

        principal = resource.kerberos_principal
Severity: Minor
Found in examples/devise/kerberos_strategy.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method assert_has_content has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def assert_has_content
        if defined?(Krb5.kt_have_content)
          Krb5.kt_have_content(Context.context.ptr, ptr)
        else # HACK
          if file?
Severity: Minor
Found in lib/kerberos_authenticator/krb5/keytab.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method verify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def verify(nofail = false, server_principal = nil, keytab = nil)
        verify_creds_opt = FFI::MemoryPointer.new :int, 2
        Krb5.verify_init_creds_opt_init(verify_creds_opt)
        Krb5.verify_init_creds_opt_set_ap_req_nofail(verify_creds_opt, nofail)
Severity: Minor
Found in lib/kerberos_authenticator/krb5/creds.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language