sue445/heart_seed

View on GitHub

Showing 4 of 6 total issues

Method read_sheet has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def self.read_sheet(sheet, row_prefix)
      header_keys = select_left_of_blank(sheet.row(HEADER_ROW))
      fixtures = {}

      (HEADER_ROW + 1 .. sheet.last_row).each do |row_num|
Severity: Minor
Found in lib/heart_seed/converter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import_all has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def self.import_all(seed_dir: HeartSeed::Helper.seed_dir, tables: ENV["TABLES"], catalogs: ENV["CATALOGS"], mode: ENV["MODE"], validate: true)
      mode ||= BULK
      target_table_names = parse_target_table_names(tables: tables, catalogs: catalogs)

      raise "require TABLES or CATALOGS if production" if HeartSeed::Helper.production? && target_table_names.empty?
Severity: Minor
Found in lib/heart_seed/db_seed.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method select_left_of_blank has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.select_left_of_blank(array)
      response = []
      array.each do |element|
        break unless element
        break if element.respond_to?(:blank?) && element.blank?
Severity: Minor
Found in lib/heart_seed/converter.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method environment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def self.environment(default = "development")
      env ||= Rails.env          if defined? Rails
      env ||= ENV["PADRINO_ENV"] if ENV["PADRINO_ENV"]
      env ||= ENV["RACK_ENV"]    if ENV["RACK_ENV"]
      env ||= default
Severity: Minor
Found in lib/heart_seed/helper.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language