sumocoders/FrameworkUserBundle

View on GitHub

Showing 5 of 7 total issues

Method editAction has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function editAction(Request $request, $id)
    {
        // fix the breadCrumb
        $this->get('framework.breadcrumb_builder')
            ->extractItemsBasedOnUri(
Severity: Major
Found in Controller/UserController.php - About 3 hrs to fix

    File UserController.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace SumoCoders\FrameworkUserBundle\Controller;
    
    use SumoCoders\FrameworkUserBundle\Entity\User;
    Severity: Minor
    Found in Controller/UserController.php - About 2 hrs to fix

      Method newAction has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function newAction(Request $request)
          {
              // fix the breadCrumb
              $this->get('framework.breadcrumb_builder')
                  ->extractItemsBasedOnUri(
      Severity: Major
      Found in Controller/UserController.php - About 2 hrs to fix

        Method createBlockUnblockForm has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function createBlockUnblockForm(User $user, $action = 'block')
            {
                $allowedActions = array(
                    'block',
                    'unblock',
        Severity: Major
        Found in Controller/UserController.php - About 2 hrs to fix

          Function editAction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function editAction(Request $request, $id)
              {
                  // fix the breadCrumb
                  $this->get('framework.breadcrumb_builder')
                      ->extractItemsBasedOnUri(
          Severity: Minor
          Found in Controller/UserController.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language