superdesk/superdesk-client-core

View on GitHub
build-tools/src/extensions/translations.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function mergeTranslationsFromExtensions has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

function mergeTranslationsFromExtensions(clientDir) {
    const translationsJsonTemp = path.join(clientDir, 'translations-json-temp');
    const mainTranslationsDir = path.join(clientDir, 'dist/languages');

    const existingTranslationFiles = new Set(
Severity: Minor
Found in build-tools/src/extensions/translations.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mergeTranslationsFromExtensions has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function mergeTranslationsFromExtensions(clientDir) {
    const translationsJsonTemp = path.join(clientDir, 'translations-json-temp');
    const mainTranslationsDir = path.join(clientDir, 'dist/languages');

    const existingTranslationFiles = new Set(
Severity: Major
Found in build-tools/src/extensions/translations.js - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if (key === '' || jsonDest[key] != null) {
                            continue; // do not overwrite meta info or existing translations
                        }
    Severity: Major
    Found in build-tools/src/extensions/translations.js - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status