Sign upLogin

svthalia/concrexit

View on GitHub
Star

Showing 227 of 702 total issues

Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def create(self, validated_data):
        shift = self.context["shift"]
        if "order_items" in validated_data:
            items_data = validated_data.pop("order_items")
            order = Order.objects.create(shift=shift, **validated_data)
Severity: Minor
Found in website/sales/api/v2/admin/serializers/order.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clean has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def clean(self):
        super().clean()
        errors = {}

        if self.membership_type == Membership.BENEFACTOR:
Severity: Minor
Found in website/registrations/models.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_serializer_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def get_serializer_class(self):
        if self.action == "retrieve":
            if self.is_self_reference() or (
                self.request.user
                and self.request.user.has_perm("members.change_profile")
Severity: Minor
Found in website/members/api/v1/viewsets.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function change_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def change_view(self, request, object_id, form_url="", extra_context=None):
        if object_id:
            try:
                obj = self.model.objects.get(pk=object_id)
                if (
Severity: Minor
Found in website/sales/admin/order_admin.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function announcements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def announcements(self, request) -> list[dict]:
        # Skip announcements for anonymous users to prevent evaluating
        # request.member too early for API requests, because DRF only sets
        # the correct request.user after evaluating the middlewares.
        if request.user.is_anonymous:
Severity: Minor
Found in website/members/apps.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clean has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def clean(self):
        super().clean()
        if self.cleaned_data["member"].profile.is_minimized:
            raise ValidationError(
                "It's not possible to renew a membership using an incomplete profile."
Severity: Minor
Found in website/registrations/forms.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_models_test_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def create_models_test_class(classname):
    """Create the class for all the model __str__ tests.

    This class is created dynamically with the type(name, bases, dict)
    function, it includes test functions to test all the models in the project.
Severity: Minor
Found in website/thaliawebsite/tests/test_models.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language