Sign upLogin

svthalia/concrexit

View on GitHub
Star
website/pizzas/views.py
12505522

Summary

Maintainability
B
5 hrs
Test Coverage

Function place_order has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

def place_order(request):
    """View that shows the detail of the current order."""
    event = FoodEvent.current()

    if not event:
Severity: Minor
Found in website/pizzas/views.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cancel_order has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def cancel_order(request):
    """View that cancels a user's order."""
    if "order" in request.POST:
        try:
            order = get_object_or_404(FoodOrder, pk=int(request.POST["order"]))
Severity: Minor
Found in website/pizzas/views.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def index(request):
    """Overview of user order for a pizza event."""
    products = Product.available_products.order_by("name")
    if not request.user.has_perm("pizzas.order_restricted_products"):
        products = products.exclude(restricted=True)
Severity: Minor
Found in website/pizzas/views.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return redirect("pizzas:index")
Severity: Major
Found in website/pizzas/views.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return redirect("pizzas:index")
Severity: Major
Found in website/pizzas/views.py - About 30 mins to fix

There are no issues that match your filters.

Category
Status