Sign upLogin

swagger-api/swagger-editor

View on GitHub
Star
src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js

Summary

Maintainability
F
6 days
Test Coverage

Function getKeywordsForPath has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

export default function getKeywordsForPath({ system, path, keywordMap }) {
  keywordMap = Object.assign({}, keywordMap)

  // is getting path was not successful stop here and return no candidates
  if (!isArray(path)) {
Severity: Minor
Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getChild has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function getChild(object, key) {
  var keys = Object.keys(object)
  var regex
  var isArrayAccess = /^\d+$/.test(key)
Severity: Minor
Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return keywordMap[0].map(item => {
        return {
          name: "array",
          value: "- " + item,
          score: 300,
Severity: Major
Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return []
    Severity: Major
    Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return []
      Severity: Major
      Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return keywordMap.map(constructAceCompletion.bind(null, "value"))
        Severity: Major
        Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return suggestionFromSchema(keywordMap)
          Severity: Major
          Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return [{
        name: "array",
        value: "- ",
        score: 300,
        meta: "array item"
            Severity: Major
            Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              export default function getKeywordsForPath({ system, path, keywordMap }) {
  keywordMap = Object.assign({}, keywordMap)

  // is getting path was not successful stop here and return no candidates
  if (!isArray(path)) {
              Severity: Major
              Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js and 1 other location - About 3 days to fix
              src/plugins/editor-autosuggest-oas3-keywords/get-keywords-for-path.js on lines 9..105

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 665.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function getChild(object, key) {
  var keys = Object.keys(object)
  var regex
  var isArrayAccess = /^\d+$/.test(key)
              Severity: Major
              Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js and 1 other location - About 1 day to fix
              src/plugins/editor-autosuggest-oas3-keywords/get-keywords-for-path.js on lines 107..133

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 206.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function constructAceCompletion(meta, keyword) {
  if(keyword.slice(0, 2) === "__") {
    return {}
  }
              Severity: Major
              Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js and 1 other location - About 5 hrs to fix
              src/plugins/editor-autosuggest-oas3-keywords/get-keywords-for-path.js on lines 145..172

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 142.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function suggestionFromSchema(map) {
  const res = toArray(mapValues(map, (val, key) => {
    const keyword = get(val, "__value", key)
    const meta = isPlainObject(val) ? "object" : "keyword"
              Severity: Major
              Found in src/plugins/editor-autosuggest-keywords/get-keywords-for-path.js and 1 other location - About 1 hr to fix
              src/plugins/editor-autosuggest-oas3-keywords/get-keywords-for-path.js on lines 135..143

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status