swaibat/Quick-credit-api-v1

View on GitHub

Showing 2 of 6 total issues

Function createTables has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const createTables = () => {

  const users = `CREATE TABLE IF NOT EXISTS
      users (
        id SERIAL PRIMARY KEY,
Severity: Minor
Found in api/services/db.js - About 1 hr to fix

    Function query has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Confirmed

    export async function query(req, res, next) {
      const { status, repaid } = req.query;
    
      if (status && repaid) {
        const loansResult = await loanObj.getLoanStatus(status, repaid);
    Severity: Minor
    Found in api/midleware/loansWare.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language