Sign upLogin

synewaves/rubillow

View on GitHub
Star

Showing 5 of 11 total issues

Method parse has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def parse
        super
        
        return if !success?
Severity: Minor
Found in lib/rubillow/models/demographics.rb - About 1 hr to fix

    Method extract_zestimate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def extract_zestimate(xml)
        extract_zpid(xml)
        extract_links(xml)
        extract_address(xml)
    Severity: Minor
    Found in lib/rubillow/models/zestimateable.rb - About 1 hr to fix

      Method parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse
        super
        
        return if !success?
      Severity: Minor
      Found in lib/rubillow/models/demographics.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method extract_links has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def extract_links(xml)
        @links = {}
        
        # TODO: clean up this logic
        if !xml.xpath('//result/links').empty?
      Severity: Minor
      Found in lib/rubillow/models/linkable.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

            if options[:regionid].nil? && options[:zip].nil? && (options[:state].nil? || options[:city].nil?) && (options[:city].nil? || options[:neighborhood].nil?)
        raise ArgumentError, "The regionid, state and city, city and neighborhood or zip option is required"
      end
      Severity: Major
      Found in lib/rubillow/neighborhood.rb - About 40 mins to fix
        Severity
        Category
        Status
        Source
        Language