Sign upLogin

syntheticore/declaire

View on GitHub
Star
src/model.js

Summary

Maintainability
F
3 days
Test Coverage

Function Instance has 217 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Instance = function() {
  var inst = {
    klass: 'Instance',
    model: null,
    id: null,
Severity: Major
Found in src/model.js - About 1 day to fix

    Function Instance has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

    var Instance = function() {
  var inst = {
    klass: 'Instance',
    model: null,
    id: null,
    Severity: Minor
    Found in src/model.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File model.js has 334 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var Query = require('./query.js');
var Collection = require('./collection.js');
var _ = require('./utils.js');
    Severity: Minor
    Found in src/model.js - About 4 hrs to fix

      Function Model has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var Model = function(dbCollection, reference, constructor) {
  var ref = separateMethods(reference);
  var model = {
    klass: 'Model',
    name: dbCollection,
      Severity: Major
      Found in src/model.js - About 2 hrs to fix

        Function save has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            save: function(values) {
      var self = this;
      return _.promise(function(ok, fail) {
        // Detect event object to allow calling from actions
        if(values && values.target) {
        Severity: Minor
        Found in src/model.js - About 1 hr to fix

          Function get has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              get: function(key) {
      // Catch remaining arguments as parameters for computed properties
      var args = Array.prototype.slice.call(arguments).splice(1);
      // Determine value
      var value = this.data.local[key];
          Severity: Minor
          Found in src/model.js - About 1 hr to fix

            Function separateMethods has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            var separateMethods = function(reference) {
  var ret = {
    defaults: {},
    methods: {},
    collections: {},
            Severity: Minor
            Found in src/model.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function Model has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            var Model = function(dbCollection, reference, constructor) {
  var ref = separateMethods(reference);
  var model = {
    klass: 'Model',
    name: dbCollection,
            Severity: Minor
            Found in src/model.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  for(var key in ref.queries) {
        var query = ref.queries[key].clone();
        inst.data.remote[key] = query;
      }
            Severity: Major
            Found in src/model.js and 1 other location - About 1 hr to fix
            src/model.js on lines 353..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  for(var key in ref.collections) {
        var collection = ref.collections[key].clone();
        inst.data.remote[key] = collection;
      }
            Severity: Major
            Found in src/model.js and 1 other location - About 1 hr to fix
            src/model.js on lines 358..361

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status