Sign upLogin

t32k/stylestats

View on GitHub
Star
lib/analyzer.js

Summary

Maintainability
F
3 days
Test Coverage

Function analyze has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

  analyze() {
    // Get analytics
    const ruleAnalysis = this.analyzeRules();
    const selectorAnalysis = this.analyzeSelectors();
    const declarationAnalysis = this.analyzeDeclarations();
Severity: Minor
Found in lib/analyzer.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function analyze has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  analyze() {
    // Get analytics
    const ruleAnalysis = this.analyzeRules();
    const selectorAnalysis = this.analyzeSelectors();
    const declarationAnalysis = this.analyzeDeclarations();
Severity: Major
Found in lib/analyzer.js - About 3 hrs to fix

    Function analyzeDeclarations has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      analyzeDeclarations() {
    // Object to return
    const result = {
      dataUriSize: '',
      importantKeywords: 0,
    Severity: Major
    Found in lib/analyzer.js - About 3 hrs to fix

      File analyzer.js has 280 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      const gzipSize = require('gzip-size');

class Analyzer {
  /**
   * @param {Array} rules
      Severity: Minor
      Found in lib/analyzer.js - About 2 hrs to fix

        Function analyzeSelectors has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          analyzeSelectors() {
    // Object to return
    const result = {
      idSelectors: 0,
      universalSelectors: 0,
        Severity: Minor
        Found in lib/analyzer.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (selector.indexOf('*') > -1) {
        const universal = selector.replace(/\[.+]/g, '');
        if (universal.indexOf('*') > -1) {
          result.universalSelectors += 1;
        }
          Severity: Major
          Found in lib/analyzer.js and 1 other location - About 1 hr to fix
          lib/analyzer.js on lines 101..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (selector.indexOf('#') > -1) {
        const id = selector.replace(/\[.+]/g, '');
        if (id.indexOf('#') > -1) {
          result.idSelectors += 1;
        }
          Severity: Major
          Found in lib/analyzer.js and 1 other location - About 1 hr to fix
          lib/analyzer.js on lines 109..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (declaration.property.indexOf('font-size') > -1) {
        result.uniqueFontSizes.push(declaration.value.replace(/!important/, '').trim());
      }
          Severity: Major
          Found in lib/analyzer.js and 1 other location - About 1 hr to fix
          lib/analyzer.js on lines 195..197

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (declaration.property.indexOf('font-family') > -1) {
        result.uniqueFontFamilies.push(declaration.value.replace(/(!important)/g, '').trim());
      }
          Severity: Major
          Found in lib/analyzer.js and 1 other location - About 1 hr to fix
          lib/analyzer.js on lines 200..202

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              result.uniqueBackgroundImages = result.uniqueBackgroundImages.filter((backgroundImage, index, array) => {
      return array.indexOf(backgroundImage) === index;
    }).sort();
          Severity: Major
          Found in lib/analyzer.js and 1 other location - About 1 hr to fix
          lib/analyzer.js on lines 233..235

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              result.uniqueFontFamilies = result.uniqueFontFamilies.filter((fontFamily, index, array) => {
      return array.indexOf(fontFamily) === index;
    }).sort();
          Severity: Major
          Found in lib/analyzer.js and 1 other location - About 1 hr to fix
          lib/analyzer.js on lines 276..278

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status