Sign upLogin

taburetkin/marionette.yat

View on GitHub
Star
coms/stateModel/viewWithStateModel-mixin.js

Summary

Maintainability
C
1 day
Test Coverage

Function enableStateModel has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    enableStateModel() {
        if (!this.stateModel) {
            this.stateModel = this.buildStateModel();
        }
        let state = this.stateModel;
Severity: Major
Found in coms/stateModel/viewWithStateModel-mixin.js - About 2 hrs to fix

    Function createHandlerContext has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function createHandlerContext(context, state, model, property, arg) {
    Severity: Minor
    Found in coms/stateModel/viewWithStateModel-mixin.js - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (arg === true) {
        cntx.property = property;
        cntx.getValue = () => model.get(property);
        cntx.handler = () => state.state(property, model.get(property));
        //stateHandler = () => state.state(property, model.get(property));
      Severity: Major
      Found in coms/stateModel/viewWithStateModel-mixin.js and 1 other location - About 1 hr to fix
      coms/stateModel/viewWithStateModel-mixin.js on lines 37..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          } else if (_.isString(arg)) {
        cntx.property = arg;
        cntx.getValue = () => model.get(property);
        cntx.handler = () => state.state(arg, model.get(property));
        //stateHandler = () => state.state(arg, model.get(property));
      Severity: Major
      Found in coms/stateModel/viewWithStateModel-mixin.js and 1 other location - About 1 hr to fix
      coms/stateModel/viewWithStateModel-mixin.js on lines 32..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          stateOff() {
        this.enableStateModel();
        let model = this.getStateModel();
        if (!model) return;
        this.stopListening(model.getEventsModel(), ...arguments);
      Severity: Major
      Found in coms/stateModel/viewWithStateModel-mixin.js and 2 other locations - About 1 hr to fix
      coms/stateModel/viewWithStateModel-mixin.js on lines 185..190
      coms/stateModel/viewWithStateModel-mixin.js on lines 191..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          stateOn() {
        this.enableStateModel();
        let model = this.getStateModel();
        if (!model) return;
        this.listenTo(model.getEventsModel(), ...arguments);
      Severity: Major
      Found in coms/stateModel/viewWithStateModel-mixin.js and 2 other locations - About 1 hr to fix
      coms/stateModel/viewWithStateModel-mixin.js on lines 185..190
      coms/stateModel/viewWithStateModel-mixin.js on lines 197..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          stateOnce() {
        this.enableStateModel();
        let model = this.getStateModel();
        if (!model) return;
        this.listenToOnce(model.getEventsModel(), ...arguments);
      Severity: Major
      Found in coms/stateModel/viewWithStateModel-mixin.js and 2 other locations - About 1 hr to fix
      coms/stateModel/viewWithStateModel-mixin.js on lines 191..196
      coms/stateModel/viewWithStateModel-mixin.js on lines 197..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status