Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/documents/AddEditFolderWindow.js

Summary

Maintainability
F
3 days
Test Coverage

Function constructor has 173 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    constructor: function(config){
        this.addEvents('foldercreated');

        var cb = Ext.extend(Ext.form.Checkbox, {
            anchor: '100%',
Severity: Major
Found in app/assets/javascripts/documents/AddEditFolderWindow.js - About 6 hrs to fix

    Function constructor has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        constructor: function(config){
        this.addEvents('foldercreated');

        var cb = Ext.extend(Ext.form.Checkbox, {
            anchor: '100%',
    Severity: Minor
    Found in app/assets/javascripts/documents/AddEditFolderWindow.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _fillPermissionsForm has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _fillPermissionsForm: function(){
        var ap = this.getComponent('tp').getComponent('sh').getComponent('ap');
        var audience = null;
        if(!ap.rendered){
            audience = this.incoming_audience;
    Severity: Minor
    Found in app/assets/javascripts/documents/AddEditFolderWindow.js - About 1 hr to fix

      Function success has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                          success: function(form, action){
                        this.loaded_data = action.result.data;

                        // set up audience panel and permissions selections here
                        var rg = this.getComponent('tp').getComponent('sh').getComponent('rh').getComponent('rg');
      Severity: Minor
      Found in app/assets/javascripts/documents/AddEditFolderWindow.js - About 1 hr to fix

        Function _fillPermissionsForm has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            _fillPermissionsForm: function(){
        var ap = this.getComponent('tp').getComponent('sh').getComponent('ap');
        var audience = null;
        if(!ap.rendered){
            audience = this.incoming_audience;
        Severity: Minor
        Found in app/assets/javascripts/documents/AddEditFolderWindow.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function beforeaction has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                                    'beforeaction': function(form, action){
                                if(action.type == 'submit')
                                {
                                    action.options.params = action.options.params || {};
        Severity: Minor
        Found in app/assets/javascripts/documents/AddEditFolderWindow.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                  if(audience && audience.users.length < 1 && (
                (ap.rendered && this.getComponent('tp').getComponent('sh').getComponent('rh').getComponent('rg').getValue().getRawValue() === 'shared') ||
                (this.loaded_data && this.loaded_data['folder[shared]'] == 'shared'))){
          this.getComponent('tp').getComponent('per').getComponent('perempty').show();
        } else if(audience) {
          Severity: Major
          Found in app/assets/javascripts/documents/AddEditFolderWindow.js - About 40 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                                else{
                                        this.getComponent('tp').getComponent('sh').getComponent('ap').disable();
                                        this.getComponent('tp').getComponent('per').getComponent('perholder').hide();
                                        this.getComponent('tp').getComponent('per').getComponent('perlabel').show();
                                    }
            Severity: Major
            Found in app/assets/javascripts/documents/AddEditFolderWindow.js and 1 other location - About 3 hrs to fix
            app/assets/javascripts/documents/AddEditFolderWindow.js on lines 87..91

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                                if(checked){
                                        this.getComponent('tp').getComponent('sh').getComponent('ap').enable();
                                        this.getComponent('tp').getComponent('per').getComponent('perlabel').hide();
                                        this.getComponent('tp').getComponent('per').getComponent('perholder').show();
                                    }
            Severity: Major
            Found in app/assets/javascripts/documents/AddEditFolderWindow.js and 1 other location - About 3 hrs to fix
            app/assets/javascripts/documents/AddEditFolderWindow.js on lines 92..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        for(var k in gval_results){
                if(k.match(/folder\[permissions\]\[\d+\]\[user_id\]/) !== null){
                    var index = k.match(/\d+/)[0];
                    var p = gval_results['folder[permissions][' + index + '][permission]'];
                    var u = gval_results[k];
            Severity: Major
            Found in app/assets/javascripts/documents/AddEditFolderWindow.js and 1 other location - About 3 hrs to fix
            app/assets/javascripts/documents/AddEditFolderWindow.js on lines 64..71

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                                    for(var k in permissions){
                                            if(k.match(/folder\[permissions\]\[\d+\]\[user_id\]/) !== null){
                                                var index = k.match(/\d+/)[0];
                                                var p = permissions['folder[permissions][' + index + '][permission]'];
                                                var u = permissions[k];
            Severity: Major
            Found in app/assets/javascripts/documents/AddEditFolderWindow.js and 1 other location - About 3 hrs to fix
            app/assets/javascripts/documents/AddEditFolderWindow.js on lines 219..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status