Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/documents/DocumentSearch.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function initComponent has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    initComponent: function(){
        this.file_actions = new Talho.ux.Documents.FileActions({});

        this.on('afterrender', function(){this.file_actions.download_frame_target = this.getEl();}, this, {delay: 1});
Severity: Major
Found in app/assets/javascripts/documents/DocumentSearch.js - About 2 hrs to fix

    Function run_search has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        run_search: function(val){
        if (!Ext.isEmpty(val) && val.length >= 2){
            var own = this.getComponent('search_form').getComponent('my_files').checked;
            var shared = this.getComponent('search_form').getComponent('shared_files').checked;
            if(own || shared){ // We only want to do this if the file is either owned or shared.
    Severity: Minor
    Found in app/assets/javascripts/documents/DocumentSearch.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status