Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/documents/DocumentViews.js

Summary

Maintainability
D
1 day
Test Coverage

File DocumentViews.js has 377 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Ext.ns('Talho.ux.Documents');

(function(){
    Talho.ux.Documents.translateMimeType = function(mime){
        if(mime.match(/image\//))
Severity: Minor
Found in app/assets/javascripts/documents/DocumentViews.js - About 5 hrs to fix

    Function uploadFile has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            uploadFile: function(mode){
            var sel = this.current_selections[0],
                folder = this.folder_tree.getSelectionModel().getSelected(),
                win;
    Severity: Major
    Found in app/assets/javascripts/documents/DocumentViews.js - About 2 hrs to fix

      Function initComponent has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              initComponent: function(){
            this.items = [
                { xtype: 'panel', defaultType: 'container', cls:'document-file-controls-sub-panel', items:[
                    { itemId: 'file_detail_container', hidden: true, layout: 'form', defaultType: 'displayfield', defaults:{style:{'padding-top': '3px'}}, labelWidth: 65, items:[
                        {itemId: 'image', xtype:'imagedisplayfield', value: ''},
      Severity: Minor
      Found in app/assets/javascripts/documents/DocumentViews.js - About 1 hr to fix

        Function translateMimeType has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            Talho.ux.Documents.translateMimeType = function(mime){
        if(mime.match(/image\//))
            return 'image';
        if(mime.match(/video\//))
            return 'video';
        Severity: Minor
        Found in app/assets/javascripts/documents/DocumentViews.js - About 1 hr to fix

          Function deleteItem has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  deleteItem: function(){
            var sel = this.current_selections[0];

            if(!sel){
                return;
          Severity: Minor
          Found in app/assets/javascripts/documents/DocumentViews.js - About 1 hr to fix

            Function moveItem has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    moveItem: function(mode){
            var sel = this.current_selections[0];
            var type = sel.get('type');

            if(sel.get('id') == null || sel.get('id') == 'null') return;
            Severity: Minor
            Found in app/assets/javascripts/documents/DocumentViews.js - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  Ext.EventManager.on(this._downloadFrame, 'load', function(){
                        // in a very strange bit of convenience, the frame load event will only fire here IF there is an error
                        // need to test the convenience on IE.
                        Ext.Msg.alert('Could Not Load File', 'There was an error downloading the file you have requested. Please contact an administrator');
                    }, this);
              Severity: Minor
              Found in app/assets/javascripts/documents/DocumentViews.js and 1 other location - About 35 mins to fix
              app/assets/javascripts/documents/Documents.js on lines 296..300

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      new file_control_button({itemId: 'copy_file', text: 'Copy to My Folders', iconCls: 'documents-move-icon', handler: this.file_actions.moveItem.createDelegate(this.file_actions, ['copy'])})
              Severity: Minor
              Found in app/assets/javascripts/documents/DocumentViews.js and 1 other location - About 35 mins to fix
              app/assets/javascripts/documents/Documents.js on lines 353..353

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status