talho/openphin

View on GitHub
app/assets/javascripts/ext/src/adapter/prototype-bridge.js

Summary

Maintainability
F
1 mo
Test Coverage

File prototype-bridge.js has 514 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Ext JS Library 3.3.0
 * Copyright(c) 2006-2010 Ext JS, Inc.
 * licensing@extjs.com
 * http://www.extjs.com/license
Severity: Major
Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 1 day to fix

    Function Ajax has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Ext.lib.Ajax = function(){
        var createSuccess = function(cb){
             return cb.success ? function(xhr){
                cb.success.call(cb.scope||window, createResponse(cb, xhr));
             } : Ext.emptyFn;
    Severity: Major
    Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 3 hrs to fix

      Function Anim has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Ext.lib.Anim = function(){
      
          var easings = {
              easeOut: function(pos) {
                  return 1-Math.pow(1-pos,2);
      Severity: Major
      Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 3 hrs to fix

        Function getXY has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getXY : function(el){ // this initially used Position.cumulativeOffset but it is not accurate enough
                var p, pe, b, scroll, bd = (document.body || document.documentElement);
                el = Ext.getDom(el);
        
                if(el == bd){
        Severity: Minor
        Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 2 hrs to fix

          Function run has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  run : function(el, args, duration, easing, cb, scope, type){
                      var o = {};
                      for(var k in args){
                          switch(k){   // scriptaculous doesn't support, so convert these
                              case 'points':
          Severity: Minor
          Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 1 hr to fix

            Function createResponse has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                var createResponse = function(cb, xhr){
                    var headerObj = {},
                        headerStr,
                        t,
                        s;
            Severity: Minor
            Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 1 hr to fix

              Function request has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      request : function(method, uri, cb, data, options){
                          var o = {
                              method: method,
                              parameters: data || '',
                              timeout: cb.timeout,
              Severity: Minor
              Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 1 hr to fix

                Function run has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        run : function(el, args, duration, easing, cb, scope, type){
                Severity: Major
                Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 50 mins to fix

                  Function color has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          color : function(el, args, duration, easing, cb, scope){
                  Severity: Minor
                  Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 45 mins to fix

                    Function formRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            formRequest : function(form, uri, cb, data, isUpload, sslUri){
                    Severity: Minor
                    Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 45 mins to fix

                      Function scroll has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              scroll : function(el, args, duration, easing, cb, scope){
                      Severity: Minor
                      Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 45 mins to fix

                        Function motion has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                motion : function(el, args, duration, easing, cb, scope){
                        Severity: Minor
                        Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 45 mins to fix

                          Function request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  request : function(method, uri, cb, data, options){
                          Severity: Minor
                          Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js - About 35 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            (function(){
                            
                            var libFlyweight,
                                version = Prototype.Version.split('.'),
                                mouseEnterSupported = (parseInt(version[0], 10) >= 2) || (parseInt(version[1], 10) >= 7) || (parseInt(version[2], 10) >= 1),
                            Severity: Major
                            Found in app/assets/javascripts/ext/src/adapter/prototype-bridge.js and 1 other location - About 1 mo to fix
                            app/assets/javascripts/ext/adapter/prototype/ext-prototype-adapter-debug.js on lines 1225..1826

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 5517.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status