talho/openphin

View on GitHub
app/assets/javascripts/ext/src/util/UpdateManager.js

Summary

Maintainability
D
2 days
Test Coverage

Function Updater has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
Open

function() {
    var BEFOREUPDATE = "beforeupdate",
        UPDATE = "update",
        FAILURE = "failure";

Severity: Minor
Found in app/assets/javascripts/ext/src/util/UpdateManager.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Updater has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function() {
    var BEFOREUPDATE = "beforeupdate",
        UPDATE = "update",
        FAILURE = "failure";

Severity: Major
Found in app/assets/javascripts/ext/src/util/UpdateManager.js - About 6 hrs to fix

    Function update has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            update : function(url, params, callback, discardUrl){
                var me = this,
                    cfg,
                    callerScope;
    
    
    Severity: Minor
    Found in app/assets/javascripts/ext/src/util/UpdateManager.js - About 1 hr to fix

      Function startAutoRefresh has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              startAutoRefresh : function(interval, url, params, callback, refreshNow){
      Severity: Minor
      Found in app/assets/javascripts/ext/src/util/UpdateManager.js - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status