Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js

Summary

Maintainability
F
3 days
Test Coverage

Function onRender has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

    onRender : function(ct, position){
        if(!this.el){
            var panelCfg = {
                autoEl: {
                    id: this.id
Severity: Minor
Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onRender has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onRender : function(ct, position){
        if(!this.el){
            var panelCfg = {
                autoEl: {
                    id: this.id
Severity: Major
Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 3 hrs to fix

    File CheckboxGroup.js has 290 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
 * Ext JS Library 3.3.0
 * Copyright(c) 2006-2010 Ext JS, Inc.
 * licensing@extjs.com
 * http://www.extjs.com/license
    Severity: Minor
    Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 2 hrs to fix

      Function onSetValue has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          onSetValue: function(id, value){
        if(arguments.length == 1){
            if(Ext.isArray(id)){
                Ext.each(id, function(val, idx){
                    if (Ext.isObject(val) && val.setValue){ // array of checkbox components to be checked
      Severity: Minor
      Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function onSetValue has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          onSetValue: function(id, value){
        if(arguments.length == 1){
            if(Ext.isArray(id)){
                Ext.each(id, function(val, idx){
                    if (Ext.isObject(val) && val.setValue){ // array of checkbox components to be checked
      Severity: Minor
      Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if(f){
                        f.setValue(id[i]);
                    }
        Severity: Major
        Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if(this.items[i].fieldLabel){
                            this.items[i].hideLabel = false;
                        }
          Severity: Major
          Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if(i>0 && i%rows==0){
                            ri++;
                        }
            Severity: Major
            Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if(this.items[i].fieldLabel){
                            this.items[i].hideLabel = false;
                        }
              Severity: Major
              Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 45 mins to fix

                Function reset has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    reset : function(){
        if (this.originalValue) {
            // Clear all items
            this.eachItem(function(c){
                if(c.setValue){
                Severity: Minor
                Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    isDirty: function(){
        //override the behaviour to check sub items.
        if (this.disabled || !this.rendered) {
            return false;
        }
                Severity: Major
                Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js and 1 other location - About 2 hrs to fix
                app/assets/javascripts/ext/src/widgets/form/CompositeField.js on lines 340..354

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    eachItem: function(fn, scope) {
        if(this.items && this.items.each){
            this.items.each(fn, scope || this);
        }
    },
                Severity: Major
                Found in app/assets/javascripts/ext/src/widgets/form/CheckboxGroup.js and 1 other location - About 1 hr to fix
                app/assets/javascripts/ext/src/widgets/form/CompositeField.js on lines 362..366

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status