Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js

Summary

Maintainability
D
2 days
Test Coverage

Function onNodeOver has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    onNodeOver : function(n, dd, e, data){
        var pt = this.getDropPoint(e, n, dd);
        var node = n.node;
        
        // auto node expand check
Severity: Minor
Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDropPoint has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    getDropPoint : function(e, n, dd){
        var tn = n.node;
        if(tn.isRoot){
            return tn.allowChildren !== false ? "append" : false; // always append for root
        }
Severity: Minor
Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isValidDropPoint has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    isValidDropPoint : function(n, pt, dd, e, data){
        if(!n || !data){ return false; }
        var targetNode = n.node;
        var dropNode = data.node;
        // default drop rules
Severity: Minor
Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function completeDrop has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    completeDrop : function(de){
        var ns = de.dropNode, p = de.point, t = de.target;
        if(!Ext.isArray(ns)){
            ns = [ns];
        }
Severity: Minor
Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onNodeOver has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onNodeOver : function(n, dd, e, data){
        var pt = this.getDropPoint(e, n, dd);
        var node = n.node;
        
        // auto node expand check
Severity: Minor
Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 1 hr to fix

    Function isValidDropPoint has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        isValidDropPoint : function(n, pt, dd, e, data){
        if(!n || !data){ return false; }
        var targetNode = n.node;
        var dropNode = data.node;
        // default drop rules
    Severity: Minor
    Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

      if(Ext.dd.DropZone){
    
Ext.tree.TreeDropZone = function(tree, config){
    /**
     * @cfg {Boolean} allowParentInsert
      Severity: Major
      Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 1 hr to fix

        Function processDrop has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            processDrop: function(target, data, point, dd, e, dropNode){
        Severity: Minor
        Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 45 mins to fix

          Function isValidDropPoint has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              isValidDropPoint : function(n, pt, dd, e, data){
          Severity: Minor
          Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 35 mins to fix

            Function afterNodeMoved has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                afterNodeMoved : function(dd, data, e, targetNode, dropNode){
            Severity: Minor
            Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 35 mins to fix

              Function onContainerDrop has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  onContainerDrop : function(dd, e, data){
        if (this.allowContainerDrop && this.isValidDropPoint({ ddel: this.tree.getRootNode().ui.elNode, node: this.tree.getRootNode() }, "append", dd, e, data)) {
            var targetNode = this.tree.getRootNode();       
            targetNode.ui.startDrop();
            var dropNode = data.node || (dd.getTreeNode ? dd.getTreeNode(data, targetNode, 'append', e) : null);
              Severity: Minor
              Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                          return "append";
              Severity: Major
              Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return overEvent.cancel === false && result !== false;
                Severity: Major
                Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return false;
                  Severity: Major
                  Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 30 mins to fix

                    Function processDrop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        processDrop: function(target, data, point, dd, e, dropNode){
        var dropEvent = {
            tree : this.tree,
            target: target,
            data: data,
                    Severity: Minor
                    Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (this.allowContainerDrop && this.isValidDropPoint({ ddel: this.tree.getRootNode().ui.elNode, node: this.tree.getRootNode() }, "append", dd, e, data)) {
            var targetNode = this.tree.getRootNode();       
            targetNode.ui.startDrop();
            var dropNode = data.node || (dd.getTreeNode ? dd.getTreeNode(data, targetNode, 'append', e) : null);
            return this.processDrop(targetNode, data, 'append', dd, e, dropNode);
                    Severity: Major
                    Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js and 1 other location - About 1 hr to fix
                    app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js on lines 152..154

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (this.allowContainerDrop && this.isValidDropPoint({ ddel: this.tree.getRootNode().ui.elNode, node: this.tree.getRootNode() }, "append", dd, e, data)) {
            return this.dropAllowed;
        }
                    Severity: Major
                    Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js and 1 other location - About 1 hr to fix
                    app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js on lines 216..221

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status