Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/ext_extensions/D3Graph.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function draw has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  draw: function(){    
    if(this.store.getCount() == 0){
      return;
    }
Severity: Minor
Found in app/assets/javascripts/ext_extensions/D3Graph.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function draw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  draw: function(){    
    if(this.store.getCount() == 0){
      return;
    }
Severity: Minor
Found in app/assets/javascripts/ext_extensions/D3Graph.js - About 1 hr to fix

    Function _drawAxes has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      _drawAxes: function(svg, x, y, padding, x_ticks, y_ticks){
    Severity: Minor
    Found in app/assets/javascripts/ext_extensions/D3Graph.js - About 45 mins to fix

      Function _drawLineGraph has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        _drawLineGraph: function(svg, series, x, y, x_field){
      Severity: Minor
      Found in app/assets/javascripts/ext_extensions/D3Graph.js - About 35 mins to fix

        Function _drawRules has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          _drawRules: function(svg, x, y, padding, count){
        Severity: Minor
        Found in app/assets/javascripts/ext_extensions/D3Graph.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status