Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/invitations/Invitations.js

Summary

Maintainability
F
4 days
Test Coverage

Function constructor has 366 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor: function(config){

    this.recipesStore = new Ext.data.JsonStore({
      url: '/admin/invitations/recipe_types.json',
      restful: true,
Severity: Major
Found in app/assets/javascripts/invitations/Invitations.js - About 1 day to fix

    File Invitations.js has 380 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    Ext.ns("Talho");

Talho.Invitations = Ext.extend(function(){}, {
  constructor: function(config){
    Severity: Minor
    Found in app/assets/javascripts/invitations/Invitations.js - About 5 hrs to fix

      Function click has 117 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  click: function(column, grid, rowIndex, e){
              if(grid.store.getAt(rowIndex).data['pending_requests'].length == 0) return;
              var i = [{
                html: 'Role'
              },{
      Severity: Major
      Found in app/assets/javascripts/invitations/Invitations.js - About 4 hrs to fix

        Function constructor has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          constructor: function(config){

    this.recipesStore = new Ext.data.JsonStore({
      url: '/admin/invitations/recipe_types.json',
      restful: true,
        Severity: Minor
        Found in app/assets/javascripts/invitations/Invitations.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function click has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    click: function(column, grid, rowIndex, e) {
              if(this.currentInvitationId != store.getAt(rowIndex).data['id']) {
                this.currentInvitationId = store.getAt(rowIndex).data['id'];
                header.setText(store.getAt(rowIndex).data['name']);
                newstore = new Ext.data.JsonStore({
        Severity: Minor
        Found in app/assets/javascripts/invitations/Invitations.js - About 1 hr to fix

          Function handler has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                            handler: function(b, e) {
                    Ext.Ajax.request({
                      url: this['approve_url'],
                      scope: b,
                      success: function(response, opts) {
          Severity: Minor
          Found in app/assets/javascripts/invitations/Invitations.js - About 1 hr to fix

            Function handler has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                              handler: function(b, e) {
                    Ext.Ajax.request({
                      url: this['deny_url'],
                      scope: b,
                      success: function(response, opts) {
            Severity: Minor
            Found in app/assets/javascripts/invitations/Invitations.js - About 1 hr to fix

              Function renderer has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                        renderer: function(value, metaData, record, rowIndex, colIndex, store) {
              Severity: Minor
              Found in app/assets/javascripts/invitations/Invitations.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      },{
        xtype: 'container',
        layout: 'hbox',
        layoutConfig: {
          align: 'middle',
                Severity: Minor
                Found in app/assets/javascripts/invitations/Invitations.js and 1 other location - About 50 mins to fix
                app/assets/javascripts/invitations/Invitations.js on lines 332..344

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      },{
        xtype: 'container',
        layout: 'hbox',
        layoutConfig: {
          align: 'middle',
                Severity: Minor
                Found in app/assets/javascripts/invitations/Invitations.js and 1 other location - About 50 mins to fix
                app/assets/javascripts/invitations/Invitations.js on lines 317..329

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                        for(var x = i + 4; x > i; x--) {
                          owner.items.items[x].destroy();
                        }
                Severity: Minor
                Found in app/assets/javascripts/invitations/Invitations.js and 1 other location - About 40 mins to fix
                app/assets/javascripts/invitations/Invitations.js on lines 255..257

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                        for(var x = i + 4; x > i; x--) {
                          owner.items.items[x].destroy();
                        }
                Severity: Minor
                Found in app/assets/javascripts/invitations/Invitations.js and 1 other location - About 40 mins to fix
                app/assets/javascripts/invitations/Invitations.js on lines 214..216

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 15 locations. Consider refactoring.
                Open

                Talho.Invitations.initialize = function(config) {
  var o = new Talho.Invitations(config);
  return o.getPanel();
};
                Severity: Major
                Found in app/assets/javascripts/invitations/Invitations.js and 14 other locations - About 35 mins to fix
                app/assets/javascripts/admin/AddUser.js on lines 83..86
                app/assets/javascripts/admin/AuditLog.js on lines 236..239
                app/assets/javascripts/admin/BatchUsers.js on lines 213..216
                app/assets/javascripts/admin/EditUsers.js on lines 182..185
                app/assets/javascripts/admin/PendingRoleRequests.js on lines 40..43
                app/assets/javascripts/dashboard/tutorials.js on lines 35..39
                app/assets/javascripts/documents/Documents.js on lines 491..494
                app/assets/javascripts/invitations/NewInvitation.js on lines 305..308
                app/assets/javascripts/profile/EditDevices.js on lines 47..50
                app/assets/javascripts/profile/EditPassword.js on lines 24..27
                app/assets/javascripts/profile/EditProfile.js on lines 139..142
                app/assets/javascripts/profile/ManageOrganizations.js on lines 48..51
                app/assets/javascripts/profile/ManageRoles.js on lines 48..51
                app/assets/javascripts/searches/AdvancedSearch.js on lines 98..102

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status