Sign upLogin

talho/openphin

View on GitHub
Star
app/assets/javascripts/invitations/NewInvitation.js

Summary

Maintainability
F
6 days
Test Coverage

Function constructor has 279 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor: function(config){
    var Invitee = Ext.data.Record.create([{
      name: 'name',
      type: 'string'
    },{
Severity: Major
Found in app/assets/javascripts/invitations/NewInvitation.js - About 1 day to fix

    File NewInvitation.js has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //= require_self

Ext.ns("Talho");

Talho.NewInvitation = Ext.extend(Talho.NewInvitationBase, {
    Severity: Minor
    Found in app/assets/javascripts/invitations/NewInvitation.js - About 2 hrs to fix

      Function constructor has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        constructor: function(config){
    var Invitee = Ext.data.Record.create([{
      name: 'name',
      type: 'string'
    },{
      Severity: Minor
      Found in app/assets/javascripts/invitations/NewInvitation.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function afterrender has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              afterrender: function() {
          var uploadButton = new Ext.ux.form.FileUploadField({
            name: 'invitation[csvfile]',
            itemId: 'myfileuploadfield',
            buttonOnly: true,
      Severity: Major
      Found in app/assets/javascripts/invitations/NewInvitation.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var topCardNav = function(incr){
      var l = Ext.getCmp('card-wizard-panel').getLayout();
      var i = l.activeItem.id.split('card-')[1];
      var next = parseInt(i, 10) + incr;
      if(this.getFormPanel().form.isValid()) {
        Severity: Major
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 1 day to fix
        app/assets/javascripts/invitations/NewInvitation.js on lines 199..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 251.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var bottomCardNav = function(incr){
      var l = Ext.getCmp('card-wizard-panel').getLayout();
      var i = l.activeItem.id.split('card-')[1];
      var next = parseInt(i, 10) + incr;
      if(this.getFormPanel().form.isValid()) {
        Severity: Major
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 1 day to fix
        app/assets/javascripts/invitations/NewInvitation.js on lines 182..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 251.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            editor.on('cancelEdit', function() {
      if(store.getCount() == 0) {
        Ext.getCmp('invitation_submit').disable();
      } else {
        Ext.getCmp('invitation_submit').enable();
        Severity: Major
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/invitations/NewInvitation.js on lines 26..32

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            editor.on('afterEdit', function() {
      if(store.getCount() == 0) {
        Ext.getCmp('invitation_submit').disable();
      } else {
        Ext.getCmp('invitation_submit').enable();
        Severity: Major
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/invitations/NewInvitation.js on lines 34..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              },{
        id: 'email',
        header: 'Email',
        dataIndex: 'email',
        sortable: true,
        Severity: Minor
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/admin/BatchUsers.js on lines 107..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              },'->',{
        id: 'bottom-card-next',
        scale: 'medium',
        enableToggle: true,
        allowDepress: false,
        Severity: Minor
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/invitations/NewInvitation.js on lines 233..241

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              },'->',{
        id: 'top-card-next',
        scale: 'medium',
        enableToggle: true,
        allowDepress: false,
        Severity: Minor
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/invitations/NewInvitation.js on lines 251..259

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            this.store.loadData(Ext.decode(action.response.responseText), !Ext.getCmp('chk-overwrite').checked);
        Severity: Minor
        Found in app/assets/javascripts/invitations/NewInvitation.js and 1 other location - About 35 mins to fix
        app/assets/javascripts/admin/BatchUsers.js on lines 34..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 15 locations. Consider refactoring.
        Open

        Talho.NewInvitation.initialize = function(config){
  var o = new Talho.NewInvitation(config);
  return o.getPanel();
};
        Severity: Major
        Found in app/assets/javascripts/invitations/NewInvitation.js and 14 other locations - About 35 mins to fix
        app/assets/javascripts/admin/AddUser.js on lines 83..86
        app/assets/javascripts/admin/AuditLog.js on lines 236..239
        app/assets/javascripts/admin/BatchUsers.js on lines 213..216
        app/assets/javascripts/admin/EditUsers.js on lines 182..185
        app/assets/javascripts/admin/PendingRoleRequests.js on lines 40..43
        app/assets/javascripts/dashboard/tutorials.js on lines 35..39
        app/assets/javascripts/documents/Documents.js on lines 491..494
        app/assets/javascripts/invitations/Invitations.js on lines 413..416
        app/assets/javascripts/profile/EditDevices.js on lines 47..50
        app/assets/javascripts/profile/EditPassword.js on lines 24..27
        app/assets/javascripts/profile/EditProfile.js on lines 139..142
        app/assets/javascripts/profile/ManageOrganizations.js on lines 48..51
        app/assets/javascripts/profile/ManageRoles.js on lines 48..51
        app/assets/javascripts/searches/AdvancedSearch.js on lines 98..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status