talho/openphin

Function _createStoreAndDataView has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  _createStoreAndDataView: function(){
    this.store = new Ext.data.Store({
      autoDestroy: true,
      autoLoad: false,
      autoSave: false,

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  grab_data: function(){
    this.store.clearFilter();
    var devices = jQuery.map(this.store.getRange(), function(e,i){ return e.data; });
    this.store.filterBy(function(e){ return e.get("state")!="deleted"; });
    return Ext.encode(devices);

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

  _destroy_handler: function(dv,index,node,e){
    var elem = Ext.get(e.getTarget());
    if (elem.hasClass("profile-destroy")) {
      this.store.getAt(index).set("state", "deleted");
      this.store.filterBy(function(e){ return e.get("state")!="deleted"; });

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

      listeners: {
        scope: this,
        'load': {fn: function(){ this.ancestor.getPanel().doLayout(); }, delay: 10},
        'add': {fn: function(){ this.ancestor.getPanel().doLayout(); }, delay: 10}
      },

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    this.items = [
      this._createStoreAndDataView(),
      {xtype: 'spacer', height: '10'},
      {xtype: 'container', layout: 'hbox', layoutConfig:{defaultMargins:'0 10 0 4'}, items:[
        {xtype: 'button', text: 'Add device', handler: this.add_device, scope: this, width:'auto'}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    this.dv = new Ext.DataView(
      {name: 'user[devices]', store: this.store, tpl: template, emptyText: 'No devices to display', deferEmptyText: false,
        multiSelect: false, singleSelect: false, itemSelector: 'li.device-item', selectedClass: 'device-selected'}
    );

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    win.addButton({xtype: 'button', text: 'Add', handler: function(){ this.add_cb(win); }, scope: this, width:'auto'});

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    win.addButton({xtype: 'button', text: 'Cancel', handler: function(){ win.close(); }, scope: this, width:'auto'});

• Read up
  Read up