Sign upLogin

tandusrl/acts_as_bookable

View on GitHub
Star

Showing 8 of 8 total issues

Method check_availability! has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

      def check_availability!(opts)
        # validates options
        self.validate_booking_options!(opts)

        # Capacity check (done first because it doesn't require additional queries)
Severity: Minor
Found in lib/acts_as_bookable/bookable/core.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method subintervals has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

      def subintervals(intervals, &block)
        raise ArgumentError.new('intervals must be an array') unless intervals.is_a? Array

        steps = [] # Steps will be extracted from intervals
        subintervals = [] # The output
Severity: Minor
Found in lib/acts_as_bookable/time_utils.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_availability! has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def check_availability!(opts)
        # validates options
        self.validate_booking_options!(opts)

        # Capacity check (done first because it doesn't require additional queries)
Severity: Major
Found in lib/acts_as_bookable/bookable/core.rb - About 2 hrs to fix

    Method subintervals has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def subintervals(intervals, &block)
        raise ArgumentError.new('intervals must be an array') unless intervals.is_a? Array

        steps = [] # Steps will be extracted from intervals
        subintervals = [] # The output
    Severity: Minor
    Found in lib/acts_as_bookable/time_utils.rb - About 1 hr to fix

      Method validate_booking_options! has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def validate_booking_options!(options)
        unpermitted_params = []
        required_params = {}

        #
      Severity: Minor
      Found in lib/acts_as_bookable/bookable/core.rb - About 1 hr to fix

        Method set_options has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def set_options
          # The default preset is 'room'
          self.booking_opts[:preset]

          defaults = nil
        Severity: Minor
        Found in lib/acts_as_bookable/bookable/core.rb - About 1 hr to fix

          Method validate_booking_options! has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

                def validate_booking_options!(options)
        unpermitted_params = []
        required_params = {}

        #
          Severity: Minor
          Found in lib/acts_as_bookable/bookable/core.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method interval_in_schedule? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def interval_in_schedule?(schedule, interval_start, interval_end)
        # Check if interval_start and interval_end falls within any occurrence
        return false if(!time_in_schedule?(schedule,interval_start) || !time_in_schedule?(schedule,interval_end))

        # Check if both interval_start and interval_end falls within the SAME occurrence
          Severity: Minor
          Found in lib/acts_as_bookable/time_utils.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language