tantalim/tantalim-server

View on GitHub
app/services/modelSaver.js

Summary

Maintainability
C
1 day
Test Coverage

Function updateData has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updateData(modelDefinition, row) {
    return new BluebirdPromise(function (resolve, reject) {
        logger.debug('starting updateData() for ', modelDefinition.name);

        checkConnection();
Severity: Major
Found in app/services/modelSaver.js - About 2 hrs to fix

    File modelSaver.js has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';
    
    var _ = require('lodash'),
        BluebirdPromise = require('bluebird'),
        knex = require('knex').knex,
    Severity: Minor
    Found in app/services/modelSaver.js - About 2 hrs to fix

      Function insertData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function insertData(modelDefinition, row) {
          return new BluebirdPromise(function (resolve, reject) {
              logger.debug('starting insertData() for ', modelDefinition.name);
              //console.log(row);
      
      
      Severity: Minor
      Found in app/services/modelSaver.js - About 1 hr to fix

        Function childUpdate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function childUpdate(modelDefinition, row, forceDelete) {
            return new BluebirdPromise(function (resolve, reject) {
                logger.debug('starting childUpdate() for ', modelDefinition.name);
        
                if (!modelDefinition.children) {
        Severity: Minor
        Found in app/services/modelSaver.js - About 1 hr to fix

          Function getSqlReadyRow has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  var sqlReadyRow = (function getSqlReadyRow() {
                      function included(field) {
                          function isDefinedAndFalse(value) {
                              if (value === undefined) {
                                  return false;
          Severity: Minor
          Found in app/services/modelSaver.js - About 1 hr to fix

            Function deleteData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function deleteData(modelDefinition, row) {
                return new BluebirdPromise(function (resolve, reject) {
                    // Delete my children first
                    childUpdate(modelDefinition, row, true)
                        .then(function () {
            Severity: Minor
            Found in app/services/modelSaver.js - About 1 hr to fix

              There are no issues that match your filters.

              Category
              Status