taskforcedev/crud-api

View on GitHub

Showing 15 of 17 total issues

Function getModel has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function getModel($model = null)
    {
        if ($model === null) {
            $model = $this->crudApi->model;
        }
Severity: Minor
Found in src/Helpers/Model.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function tableContent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function tableContent($fields, $instance)
    {
        $output = '';
        foreach ($fields as $f) {
            if ($this->isIdField($f)) {
Severity: Minor
Found in src/Helpers/Field.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getModel has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getModel($model = null)
    {
        if ($model === null) {
            $model = $this->crudApi->model;
        }
Severity: Minor
Found in src/Helpers/Model.php - About 1 hr to fix

    Method formCreate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formCreate($fields)
        {
            $output = '';
    
            foreach ($fields as $f) {
    Severity: Minor
    Found in src/Helpers/Field.php - About 1 hr to fix

      Method formEdit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function formEdit($fields)
          {
              $output = '';
              foreach ($fields as $f) {
                  $ucF = ucfirst($f);
      Severity: Minor
      Found in src/Helpers/Field.php - About 1 hr to fix

        Function renderFields has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function renderFields($type, $fields = [])
            {
                if (empty($fields)) {
                    $fields = $this->getFields();
                }
        Severity: Minor
        Found in src/Helpers/CrudApi.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method renderFields has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function renderFields($type, $fields = [])
            {
                if (empty($fields)) {
                    $fields = $this->getFields();
                }
        Severity: Minor
        Found in src/Helpers/CrudApi.php - About 1 hr to fix

          Function formEdit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function formEdit($fields)
              {
                  $output = '';
                  foreach ($fields as $f) {
                      $ucF = ucfirst($f);
          Severity: Minor
          Found in src/Helpers/Field.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function formCreate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function formCreate($fields)
              {
                  $output = '';
          
                  foreach ($fields as $f) {
          Severity: Minor
          Found in src/Helpers/Field.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getRelatedModel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getRelatedModel($f)
              {
                  $field = $this->getRelatedField($f);
                  $model = $this->getModel($field);
          
          
          Severity: Minor
          Found in src/Helpers/CrudApi.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getRelatedOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getRelatedOptions($relation)
              {
                  $output = '';
          
                  if (!method_exists($relation, 'toOptions')) {
          Severity: Minor
          Found in src/Helpers/CrudApi.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in src/Helpers/Model.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $this->modelHelper->getModel();
            Severity: Major
            Found in src/Helpers/CrudApi.php - About 30 mins to fix

              Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function update(Request $request, $model)
                  {
                      $this->apiHelper->setModel($model);
                      $fqModel = $this->apiHelper->getModel();
              
              
              Severity: Minor
              Found in src/Http/Controllers/AdminController.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getPrimaryField has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getPrimaryField($item, $config = null)
                  {
                      /* If config is not overridden then load crudapi config */
                      if ($config === null) {
                          $config = config('crudapi');
              Severity: Minor
              Found in src/Helpers/Field.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language